From: "Milan P. Gandhi" <mgandhi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Martin Wilck <mwilck-IBi9RG/b67k@public.gmane.org>,
initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v2] dracut: Verify multipath config_dir option
Date: Tue, 4 Feb 2020 10:39:51 +0530 [thread overview]
Message-ID: <b9ed411c-16c8-9805-4935-a2e31f5961f6@redhat.com> (raw)
In-Reply-To: <89c04b96b10322918b1fce9afda885254556f3af.camel-IBi9RG/b67k@public.gmane.org>
On 2/3/20 6:29 PM, Martin Wilck wrote:
> On Mon, 2020-02-03 at 17:00 +0530, Milan P. Gandhi wrote:
>> The 90multipath/module-setup.sh file currently does not check the
>> dm-multipath config_dir option. This option in multipath.conf file is
>> used to specify a custom directory/path that contains the multipath
>> configuration files. It's default value is /etc/multipath/conf.d
>>
>> Currently install function of module-setup.sh has hardcoded the above
>> path, but users could change it with config_dir option. So, adding
>> steps to read the path specified with config_dir option and add
>> these configuration files to the initial ram disk image.
>>
>> Signed-off-by: Milan P. Gandhi <mgandhi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>>
>> changes v2:
>> - Removed awk/sed usage to get config_dir path
>> - Added a check to verify if path specifed with
>> config_dir is actual directory
>>
>> modules.d/90multipath/module-setup.sh | 16 +++++++++++++++-
>> 1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/modules.d/90multipath/module-setup.sh
>> b/modules.d/90multipath/module-setup.sh
>> index 48a9d09a..7609ff52 100755
>> --- a/modules.d/90multipath/module-setup.sh
>> +++ b/modules.d/90multipath/module-setup.sh
>> @@ -79,6 +79,20 @@ install() {
>> }
>> }
>>
>> + # Include multipath configuration files from path specified with
>> config_dir
>> + while read _k _v; do
>> + if [[ "$_k" = config_dir ]]; then
>> + _v=${_v#\"}
>> + config_dir=${_v%\"}
>> + fi
>> + done < <(/sbin/multipath -t)
>> +
>> + if [ -d "$config_dir" ]; then
>> + config_dir+="/*"
>> + else
>> + echo "multipath.conf: config_dir - No such directory
>> $config_dir"
>
> I believe new code should use derror or dwarning here instead of plain
> echo. Otherwise, it's looking good.
Sure, I will update it.
Thanks,
Milan.
prev parent reply other threads:[~2020-02-04 5:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 11:30 [PATCH v2] dracut: Verify multipath config_dir option Milan P. Gandhi
2020-02-03 12:05 ` Dracut GitHub Import Bot
2020-02-03 12:59 ` Martin Wilck
[not found] ` <89c04b96b10322918b1fce9afda885254556f3af.camel-IBi9RG/b67k@public.gmane.org>
2020-02-04 5:09 ` Milan P. Gandhi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9ed411c-16c8-9805-4935-a2e31f5961f6@redhat.com \
--to=mgandhi-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mwilck-IBi9RG/b67k@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).