From: Jeremy Linton <lintonrjeremy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] arm64: mmc drivers
Date: Wed, 26 Apr 2017 22:12:30 -0500 [thread overview]
Message-ID: <CAEFTgiwuMftYLJbyCXJLt3y=GjQRC1H0BjksngLugGggHGJOwg@mail.gmail.com> (raw)
In-Reply-To: <20170427025929.10982-1-lintonrjeremy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi,
Having messed with this for the past couple hours, I'm not convinced
this solution is any better than the previous patch. What is basically
happening is that dw_mmc is utilizing mmc_add_host, which pulls it
into the initrd, but it has "dependencies" on other drivers
registering dw_mc_probe routines before it will register a mmc host.
The platform driver registers a dw_mmc_probe routine, but not before
the k3 driver registers via pltfm_register. Since the dw_mmc_k3 driver
get triggered via its OF/DT device description, it pulls in the rest
of the stack in order to resolve all the missing symbols. So, maybe
the dw_mmc driver needs to be more monolithic, but good luck with
that...
So, in the end I think the previous version might be a more generic solution..
On Wed, Apr 26, 2017 at 9:59 PM, Jeremy Linton <lintonrjeremy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> It is common for arm64 devices to boot from mmc & sd devices
> we need to assure that those drivers make it to the initrd.
>
> Signed-off-by: Jeremy Linton <lintonrjeremy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> modules.d/90kernel-modules/module-setup.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/modules.d/90kernel-modules/module-setup.sh b/modules.d/90kernel-modules/module-setup.sh
> index b1bced69..863ce932 100755
> --- a/modules.d/90kernel-modules/module-setup.sh
> +++ b/modules.d/90kernel-modules/module-setup.sh
> @@ -25,10 +25,12 @@ installkernel() {
>
> if [[ "$(uname -m)" == arm* || "$(uname -m)" == aarch64 ]]; then
> # arm/aarch64 specific modules
> + _blockfuncs+='|dw_mc_probe|dw_mci_pltfm_register'
> instmods \
> "=drivers/clk" \
> "=drivers/dma" \
> "=drivers/i2c/busses" \
> + "=drivers/mfd" \
> "=drivers/phy" \
> "=drivers/power" \
> "=drivers/regulator" \
> --
> 2.12.2
>
prev parent reply other threads:[~2017-04-27 3:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 2:59 [PATCH v2] arm64: mmc drivers Jeremy Linton
[not found] ` <20170427025929.10982-1-lintonrjeremy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-27 3:03 ` Dracut GitHub Import Bot
2017-04-27 3:12 ` Jeremy Linton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEFTgiwuMftYLJbyCXJLt3y=GjQRC1H0BjksngLugGggHGJOwg@mail.gmail.com' \
--to=lintonrjeremy-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).