From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Zhiguo Deng
<bjzgdeng-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Patch] Check rd.zfcp= format in dracut hook:cmdline process stage
Date: Fri, 13 Nov 2015 14:02:38 +0100 [thread overview]
Message-ID: <5645DF6E.4020804@redhat.com> (raw)
In-Reply-To: <1444961074-5096-1-git-send-email-bjzgdeng-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
On 16.10.2015 04:04, Zhiguo Deng wrote:
> When using rd.zfcp= parameter in generic.prm file, wrong format
> parameters will prevent the zfcp driver to add the correct SCSI
> disk. dracut should die when a wrong rd.zfcp= parameter supplied.
>
> Signed-off-by: Zhiguo Deng <bjzgdeng-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> ---
> modules.d/95zfcp/parse-zfcp.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/modules.d/95zfcp/parse-zfcp.sh b/modules.d/95zfcp/parse-zfcp.sh
> index 9b22d93..91d790b 100755
> --- a/modules.d/95zfcp/parse-zfcp.sh
> +++ b/modules.d/95zfcp/parse-zfcp.sh
> @@ -5,6 +5,8 @@
> getargbool 1 rd.zfcp.conf -d -n rd_NO_ZFCPCONF || rm /etc/zfcp.conf
>
> for zfcp_arg in $(getargs rd.zfcp -d 'rd_ZFCP='); do
> + echo $zfcp_arg | grep '0\.[0-9a-fA-F]\.[0-9a-fA-F]\{4\},0x[0-9a-fA-F]\{16\},0x[0-9a-fA-F]\{16\}' >/dev/null
> + test $? -ne 0 && die "For argument 'rd.zfcp=$zfcp_arg'\nSorry, invalid format."
> (
> IFS=","
> set $zfcp_arg
>
Thanks! Pushed.
prev parent reply other threads:[~2015-11-13 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 2:04 [Patch] Check rd.zfcp= format in dracut hook:cmdline process stage Zhiguo Deng
[not found] ` <1444961074-5096-1-git-send-email-bjzgdeng-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2015-11-13 13:02 ` Harald Hoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5645DF6E.4020804@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=bjzgdeng-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).