From: "Milan P. Gandhi" <mgandhi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Martin Wilck <mwilck-IBi9RG/b67k@public.gmane.org>,
initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] dracut: Verify multipath config_dir option
Date: Mon, 3 Feb 2020 17:19:03 +0530 [thread overview]
Message-ID: <41b94406-a790-90e0-796f-9ea461351e75@redhat.com> (raw)
In-Reply-To: <cc660dff208809a5511ab837f4d781d8faeae442.camel-IBi9RG/b67k@public.gmane.org>
On 1/31/20 2:05 PM, Martin Wilck wrote:
> Hello Milan,
>
> thanks a lot for your response. I'm fine with your suggestions.
>
> On Fri, 2020-01-31 at 13:28 +0530, Milan P. Gandhi wrote:
>> On Wed, Jan 29, 2020 at 10:49:21AM +0100, Martin Wilck wrote:
>>>
>>> The path (/usr/sbin/multipath) is inconsistent with what we use in
>>> multipathd.service (/sbin/multipath). I'm not against changing this
>>> to
>>> /usr, but we should be consistent.
>>
>> I used (/usr/sbin/multipath) because location of multipath binary is
>> shown in /usr/sbin. I will change it to /sbin/multipath to make it
>> more
>> consistent with the systemctl output for multipathd.service
>
> Well, Fedora made the /usr move, which openSUSE hasn't completed yet.
> In general IMO using /usr/sbin is fine, distributions can
> patch this as it fits. But for clarity, the move should be made in a
> separate patch, so I for your patch, sticking with /sbin is better.
>
>> $ whereis multipath
>> multipath: /usr/sbin/multipath /usr/lib64/multipath [...]
>>
>>> And: fall back to /etc/multipath/conf.d if the command fails for
>>> some
>>> reason?
>>
>> The 'multipath -t' command runs successfully even when multipathd
>> itself
>> is stopped. And config_dir option is one of the built-in parameters,
>> so
>> if users do not modify it then it is automatically set to
>> /etc/multipath/conf.d
>
> Right, that makes sense. If "multipath -t" fails, something is really
> fishy and we should probably error out.
>
>> I can add a check to verify if the config_dir parameter read from
>> multipath -t is an actual directory, and if not, fall back to above
>> default path - /etc/multipath/conf.d
>
> I'm not sure about that. If config_dir exists and is not a directory,
> we should error out. If it doesn't exist, we should just skip it.
Thanks Martin!
I have just now sent an updated patch with the changes.
> Btw, while you are at it: There's also the "multipath_dir" config
> option that specifies the location of the "plugin" libraries for
> multipath. This stuff is currently installed via
>
> inst_libdir_file "libmultipath*" "multipath/"
>
> But in theory at least, users can change this directory, and if dracut
> supports a modified "config_dir", it might as well support a modified
> "multipath_dir." You may argue that that's unlikely to be modified, but
> the same can be said about config_dir. Just a suggestion.
>
Users can change "multipath_dir" config option as well, but currently
there is no check for this option. I will soon send a patch to verify
"multipath_dir" option as well.
Regards,
Milan.
prev parent reply other threads:[~2020-02-03 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 12:08 [PATCH] dracut: Verify multipath config_dir option Milan P. Gandhi
2020-01-21 13:02 ` Dracut GitHub Import Bot
2020-01-29 9:49 ` Martin Wilck
[not found] ` <2c0c0f100442edd43b10085fa47177b54cd6d0c9.camel-IBi9RG/b67k@public.gmane.org>
2020-01-31 7:58 ` Milan P. Gandhi
2020-01-31 8:35 ` Martin Wilck
[not found] ` <cc660dff208809a5511ab837f4d781d8faeae442.camel-IBi9RG/b67k@public.gmane.org>
2020-02-03 11:49 ` Milan P. Gandhi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41b94406-a790-90e0-796f-9ea461351e75@redhat.com \
--to=mgandhi-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mwilck-IBi9RG/b67k@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).