From: Greg KH <gregkh@linuxfoundation.org>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, zohar@linux.ibm.com,
initramfs@vger.kernel.org, Rob Landley <rob@landley.net>
Subject: Re: [PATCH] rootfs: Fix support for rootfstype= when root= is given
Date: Tue, 14 Nov 2023 08:19:12 -0500 [thread overview]
Message-ID: <2023111455-fabulous-simmering-51fc@gregkh> (raw)
In-Reply-To: <20231113211735.23267-1-stefanb@linux.ibm.com>
On Mon, Nov 13, 2023 at 04:17:35PM -0500, Stefan Berger wrote:
> Documentation/filesystems/ramfs-rootfs-initramfs.rst states:
>
> If CONFIG_TMPFS is enabled, rootfs will use tmpfs instead of ramfs by
> default. To force ramfs, add "rootfstype=ramfs" to the kernel command
> line.
>
> This currently does not work when root= is provided since then
> saved_root_name contains a string and initfstype= is ignored. Therefore,
> ramfs is currently always chosen when root= is provided.
>
> The current behavior for rootfs's filesystem is:
>
> root= | initfstype= | chosen rootfs filesystem
> ------------+-------------+--------------------------
> unspecified | unspecified | tmpfs
> unspecified | tmpfs | tmpfs
> unspecified | ramfs | ramfs
> provided | ignored | ramfs
>
> initfstype= should be respected regardless whether root= is given,
> as shown below:
>
> root= | initfstype= | chosen rootfs filesystem
> ------------+-------------+--------------------------
> unspecified | unspecified | tmpfs (as before)
> unspecified | tmpfs | tmpfs (as before)
> unspecified | ramfs | ramfs (as before)
> provided | unspecified | ramfs (compatibility with before)
> provided | tmpfs | tmpfs (new)
> provided | ramfs | ramfs (new)
>
> This table represents the new behavior.
>
> Fixes: 6e19eded3684 ("initmpfs: use initramfs if rootfstype= or root= specified")
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: Rob Landley <rob@landley.net>
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
> init/do_mounts.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You have marked a patch with a "Fixes:" tag for a commit that is in an
older released kernel, yet you do not have a cc: stable line in the
signed-off-by area at all, which means that the patch will not be
applied to any older kernel releases. To properly fix this, please
follow the documented rules in the
Documentation/process/stable-kernel-rules.rst file for how to resolve
this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
prev parent reply other threads:[~2023-11-14 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 21:17 [PATCH] rootfs: Fix support for rootfstype= when root= is given Stefan Berger
2023-11-14 13:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023111455-fabulous-simmering-51fc@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=initramfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob@landley.net \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).