initramfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Federico Vaga <federico.vaga-vJEk5272eHo@public.gmane.org>
To: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: dracut: 98syslog auto-detect feature
Date: Tue, 3 Aug 2021 17:24:56 +0200	[thread overview]
Message-ID: <20210803152456.lkpnzijjy7pojmnw@cwe-513-vol689.cern.ch> (raw)

Hello,

I had a look to the dracut syslog module and I've notice that, despite
the code parses the syslog.type argument, it does not actually run
anything but `rsyslogd`.

It's like this since its introduction, the code seems ready to run
`syslogd` or `syslog-ng` but it does not do it.  The
`rsyslogd-start.sh`, despite the name, is written to start any of the
three services, only that at the end it runs only `rsyslogd` (so,
perhaps the name is indeed correct). Then, `syslog-cleanup.sh`
executes the stop service `"${syslogtype}"-stop`, but the only
"*-stop" script available is for rsyslogd.

Am I missing something? If not, I see the following options:

1 clarify that this module supports only "rsyslogd":
1.a by adding "warn" when syslog or syslog-ng are selected
1.b by documenting it
1.c by renaming the module 98rsyslog and removing the auto selection

2 add support for syslog and syslog-ng (even though, nobody complained in 10 years)

                 reply	other threads:[~2021-08-03 15:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210803152456.lkpnzijjy7pojmnw@cwe-513-vol689.cern.ch \
    --to=federico.vaga-vjek5272eho@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).