From: Pingfan Liu <piliu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Liu ping fan <kernelfans-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] modules.d: introduce ssh-server module to provide service
Date: Wed, 21 Jun 2017 22:23:16 -0400 (EDT) [thread overview]
Message-ID: <1765900923.25427268.1498098196908.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <df37de69-8998-de90-d2cd-f3d619fff8d6-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
----- Original Message -----
> From: "Harald Hoyer" <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> To: "Liu ping fan" <kernelfans-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Pingfan Liu" <piliu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Sent: Wednesday, June 21, 2017 10:41:50 PM
> Subject: Re: [PATCH] modules.d: introduce ssh-server module to provide service
>
> On 12.06.2017 07:47, Liu ping fan wrote:
> > Hi Harald, what is your opinion of such functionality?
>
> yeah, nice, but some issues:
>
> 1) "inst" should be used instead of "inst_simple" for executables and *.so
> 2) That is a long hardcoded list of dependencies. Are they all needed?
> 3) The module should probably be renamed to rhel-7-ssh-server or a similar
> name
> to reflect, that it is most likely only working on this distribution
> variant
> 4) Does it have to be shipped in upstream dracut? Looks like this can live
> totally
> fine in a project, which lives outside of dracut.
>
Ah, I brought up this patch to ease the remote debugging on customer env. And usually the bug reporter is not familiar with detail, and it cost some time to communicate. With this patch, it is more easy to debug the initrd issue with capture-kernel.
It is ok if you think it is better to keep this patch lives outside of dracut. I can ask the customer to install it by manual.
Thanks and regards,
Pingfan
prev parent reply other threads:[~2017-06-22 2:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 2:39 [PATCH] modules.d: introduce ssh-server module to provide service Pingfan Liu
[not found] ` <1495593594-26460-1-git-send-email-piliu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-05-24 3:04 ` Dracut GitHub Import Bot
2017-05-26 3:23 ` Dave Young
[not found] ` <20170526032330.GA4475-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-05-27 4:44 ` Pingfan Liu
2017-06-12 5:47 ` Liu ping fan
[not found] ` <CAFgQCTtORd=carAxERPCh5GKhv7dmkGn1ios6-m885X1-JsrqA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-21 14:41 ` Harald Hoyer
[not found] ` <df37de69-8998-de90-d2cd-f3d619fff8d6-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-06-21 15:14 ` Daniel Molkentin
[not found] ` <7871761b-2b6a-edd6-da43-35c17bebcd92-l3A5Bk7waGM@public.gmane.org>
2017-06-22 2:13 ` Pingfan Liu
2017-06-22 2:23 ` Pingfan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1765900923.25427268.1498098196908.JavaMail.zimbra@redhat.com \
--to=piliu-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kernelfans-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).