From: Krzysztof Kozlowski <krzk@kernel.org>
To: FLAVIO SULIGOI <f.suligoi@asem.it>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: EXTERNAL: Re: [PATCH v2 5/5] arm64: dts: qcom: sa8775p-ride: remove tx-sched-sp property
Date: Fri, 19 Apr 2024 15:33:48 +0200 [thread overview]
Message-ID: <f0c0a324-72a7-4791-90cf-51a2cee59479@kernel.org> (raw)
In-Reply-To: <PH0PR22MB3789D39990E952F4947C04C1FA0D2@PH0PR22MB3789.namprd22.prod.outlook.com>
On 19/04/2024 10:45, FLAVIO SULIGOI wrote:
> Hi Krzysztof,
>
> ...
>
>> On 18/04/2024 14:28, Flavio Suligoi wrote:
>>> Strict priority for the tx scheduler is by default in Linux driver, so
>>> the tx-sched-sp property was removed in commit aed6864035b1 ("net:
>> stmmac:
>>> platform: Delete a redundant condition branch").
>>>
>>> So we can safely remove this property from this device-tree.
>>>
>>> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
>>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> NAK. Not true. Please point me to my review for this patch.
>
> I'm very sorry for the misunderstanding, I saw your reply in:
>
> https://lore.kernel.org/netdev/010d67c7-ca71-43fc-a3e3-ec3e5cd8b149@kernel.org/
>
> and thought it might be okay for all the other patches.
Where was it replied? In patch 5.
Why can't you use b4 for this? It solves the problems.
>
> Do you want me to resend a v3 version of the patches without the
> "Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>" ?
Yes, you must send new version because you added fake tags. Use b4
trailers to collect tags.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-19 13:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 12:28 [PATCH v2 0/5] arm64: dts: remove tx-sched-sp property in snps,dwmac Flavio Suligoi
2024-04-18 12:28 ` [PATCH v2 1/5] arm64: dts: freescale: imx8mp-beacon: remove tx-sched-sp property Flavio Suligoi
2024-04-18 16:57 ` Krzysztof Kozlowski
2024-04-18 12:28 ` [PATCH v2 2/5] arm64: dts: freescale: imx8mp-evk: " Flavio Suligoi
2024-04-18 16:58 ` Krzysztof Kozlowski
2024-04-18 12:28 ` [PATCH v2 3/5] arm64: dts: freescale: imx8mp-verdin: " Flavio Suligoi
2024-04-18 16:58 ` Krzysztof Kozlowski
2024-04-18 12:28 ` [PATCH v2 4/5] arm64: dts: qcom: sa8540p-ride: " Flavio Suligoi
2024-04-18 12:28 ` [PATCH v2 5/5] arm64: dts: qcom: sa8775p-ride: " Flavio Suligoi
2024-04-18 16:59 ` Krzysztof Kozlowski
2024-04-19 8:45 ` EXTERNAL: " FLAVIO SULIGOI
2024-04-19 13:33 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0c0a324-72a7-4791-90cf-51a2cee59479@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.suligoi@asem.it \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).