From: Frank Li <Frank.li@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Christian Gmeiner <christian.gmeiner@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Christian Gmeiner <cgmeiner@igalia.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8qm: Add GPU nodes
Date: Thu, 2 May 2024 23:05:39 -0400 [thread overview]
Message-ID: <ZjRUgze4iC5O0Iy9@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <CAOMZO5CY8PQN7b01N+oNO=92CVtPPfWzuzxphs49gh+4H+58Mw@mail.gmail.com>
On Thu, May 02, 2024 at 08:01:37PM -0300, Fabio Estevam wrote:
> Hi Christian,
>
> On Thu, May 2, 2024 at 6:58 PM Christian Gmeiner
> <christian.gmeiner@gmail.com> wrote:
> >
> > From: Christian Gmeiner <cgmeiner@igalia.com>
> >
> > Add the DT node for the GPU core found on the i.MX8QM.
> >
> > etnaviv-gpu 53100000.gpu: model: GC7000, revision: 6009
> > [drm] Initialized etnaviv 1.4.0 20151214 for etnaviv on minor 0
> >
> > Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > index b3d01677b70c..54879ae1d7d5 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > @@ -467,6 +467,7 @@ drc_crit0: trip1 {
> > #include "imx8-ss-dma.dtsi"
> > #include "imx8-ss-conn.dtsi"
> > #include "imx8-ss-lsio.dtsi"
> > + #include "imx8-ss-gpu0.dtsi"
>
> Nit: better put it in alphabetical order.
No, it should be order by subsystem register address. gpu is 53100000.
should be between imx8-ss-vpu and imx8-ss-img.
Frank
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
prev parent reply other threads:[~2024-05-03 3:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 21:57 [PATCH] arm64: dts: imx8qm: Add GPU nodes Christian Gmeiner
2024-05-02 23:01 ` Fabio Estevam
2024-05-03 3:05 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjRUgze4iC5O0Iy9@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=cgmeiner@igalia.com \
--cc=christian.gmeiner@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).