From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Conor Dooley <conor@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Lucas Stach <l.stach@pengutronix.de>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev
Subject: Re: [PATCH v3 1/1] dt-bindings: interrupt-controller: fsl, irqsteer: Add imx8qxp support
Date: Tue, 23 Apr 2024 08:26:55 +0200 [thread overview]
Message-ID: <6041240.lOV4Wx5bFT@steina-w> (raw)
In-Reply-To: <20240422-channel-emission-d485dee6ae48@spud>
Hi Conor,
cc'ed imx@lists.linux.dev
Am Montag, 22. April 2024, 17:48:20 CEST schrieb Conor Dooley:
> On Mon, Apr 22, 2024 at 08:49:49AM +0200, Alexander Stein wrote:
> > Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific
> > compatible, which also requires a power-domain.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > Thanks for the feedback.
> >
> > Changes in v3:
> > * Move 'allOf' before 'additionalProperties'
> > * Remove superfluous 'minItems: 1'
> >
> > .../interrupt-controller/fsl,irqsteer.yaml | 17 ++++++++++++++++-
> > 1 file changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > index 20ad4ad82ad64..3d33b75d6ecfa 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > @@ -14,7 +14,9 @@ properties:
> > oneOf:
> > - const: fsl,imx-irqsteer
> > - items:
> > - - const: fsl,imx8m-irqsteer
> > + - enum:
> > + - fsl,imx8m-irqsteer
> > + - fsl,imx8qxp-irqsteer
> > - const: fsl,imx-irqsteer
> >
> > reg:
> > @@ -42,6 +44,9 @@ properties:
> > clock-names:
> > const: ipg
> >
> > + power-domains:
> > + maxItems: 1
> > +
> > interrupt-controller: true
> >
> > "#interrupt-cells":
> > @@ -70,6 +75,16 @@ required:
> > - fsl,channel
> > - fsl,num-irqs
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: fsl,imx8qxp-irqsteer
> > + then:
> > + required:
> > + - power-domains
>
> Provided the power domains are optional on the existing platforms,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> otherwise,
> else:
> properties:
> power-domains: false
A power-domain is used on imx8mp, but imx8mq does not.
Best regards,
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next parent reply other threads:[~2024-04-23 6:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240422064949.70778-1-alexander.stein@ew.tq-group.com>
[not found] ` <20240422-channel-emission-d485dee6ae48@spud>
2024-04-23 6:26 ` Alexander Stein [this message]
2024-04-23 17:25 ` [PATCH v3 1/1] dt-bindings: interrupt-controller: fsl, irqsteer: Add imx8qxp support Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6041240.lOV4Wx5bFT@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).