From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: Conor Culhane <conor.culhane@silvaco.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-i3c@lists.infradead.org (moderated list:SILVACO I3C
DUAL-ROLE MASTER), linux-kernel@vger.kernel.org (open list),
imx@lists.linux.dev
Subject: Re: [PATCH 2/2] i3c: master: svc: fix invalidate IBI type and miss call client IBI handler
Date: Mon, 6 May 2024 10:59:40 +0200 [thread overview]
Message-ID: <20240506105940.5d8d2308@xps-13> (raw)
In-Reply-To: <20240424190030.857632-2-Frank.Li@nxp.com>
Hi Frank,
Frank.Li@nxp.com wrote on Wed, 24 Apr 2024 15:00:30 -0400:
> In an In-Band Interrupt (IBI) handle, the code logic is as follows:
>
> 1: writel(SVC_I3C_MCTRL_REQUEST_AUTO_IBI | SVC_I3C_MCTRL_IBIRESP_AUTO,
> master->regs + SVC_I3C_MCTRL);
>
> 2: ret = readl_relaxed_poll_timeout(master->regs + SVC_I3C_MSTATUS, val,
> SVC_I3C_MSTATUS_IBIWON(val), 0, 1000);
> ...
> 3: ibitype = SVC_I3C_MSTATUS_IBITYPE(status);
> ibiaddr = SVC_I3C_MSTATUS_IBIADDR(status);
>
> SVC_I3C_MSTATUS_IBIWON may be set before step 1. Thus, step 2 will return
> immediately, and the I3C controller has not sent out the 9th SCL yet.
> Consequently, ibitype and ibiaddr are 0, resulting in an unknown IBI type
> occurrence and missing call I3C client driver's IBI handler.
>
> A typical case is that SVC_I3C_MSTATUS_IBIWON is set when an IBI occurs
> during the controller send start frame in svc_i3c_master_xfer().
>
> Clear SVC_I3C_MSTATUS_IBIWON before issue SVC_I3C_MCTRL_REQUEST_AUTO_IBI
> to fix this issue.
>
> Cc: stable@vger.kernel.org
> Fixes: 5e5e3c92e748 ("i3c: master: svc: fix wrong data return when IBI happen during start frame")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/i3c/master/svc-i3c-master.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index a2298ab460a37..3bfe8e694f840 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -415,6 +415,9 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
> int ret;
>
> mutex_lock(&master->lock);
> + /* Clear the interrupt status */
Could you improve the comment to explain why this is needed here?
Otherwise seems okay, but I don't have any strong feelings here.
> + writel(SVC_I3C_MINT_IBIWON, master->regs + SVC_I3C_MSTATUS);
> +
> /* Acknowledge the incoming interrupt with the AUTOIBI mechanism */
> writel(SVC_I3C_MCTRL_REQUEST_AUTO_IBI |
> SVC_I3C_MCTRL_IBIRESP_AUTO,
> @@ -429,9 +432,6 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
> goto reenable_ibis;
> }
>
> - /* Clear the interrupt status */
> - writel(SVC_I3C_MINT_IBIWON, master->regs + SVC_I3C_MSTATUS);
> -
> status = readl(master->regs + SVC_I3C_MSTATUS);
> ibitype = SVC_I3C_MSTATUS_IBITYPE(status);
> ibiaddr = SVC_I3C_MSTATUS_IBIADDR(status);
Thanks,
Miquèl
next prev parent reply other threads:[~2024-05-06 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 19:00 [PATCH 1/2] i3c: master: svc: change ENXIO to EAGAIN when IBI occurs during start frame Frank Li
2024-04-24 19:00 ` [PATCH 2/2] i3c: master: svc: fix invalidate IBI type and miss call client IBI handler Frank Li
2024-05-06 8:59 ` Miquel Raynal [this message]
2024-05-06 8:54 ` [PATCH 1/2] i3c: master: svc: change ENXIO to EAGAIN when IBI occurs during start frame Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506105940.5d8d2308@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor.culhane@silvaco.com \
--cc=imx@lists.linux.dev \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).