From: Jon Masters <jcm@redhat.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [patch 1/2] Command line and documentation 1
Date: Sun, 8 Jul 2018 20:33:02 -0400 [thread overview]
Message-ID: <f7bfed24-ca0e-54a4-a355-c9c694ea7250@redhat.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.1807082222030.997@cbobk.fhfr.pm>
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
On 07/08/2018 04:32 PM, speck for Jiri Kosina wrote:
> On Sun, 8 Jul 2018, speck for Thomas Gleixner wrote:
>
>> From: Jiri Kosina <jkosina@suse.cz>
>> Subject: [patch 1/2] x86/bugs, kvm: introduce boot-time control of L1TF mitigations
>
> Thanks a lot for polishing it for me; looks pretty good now. Two small
> nits (apart from the pr_warn -> pr_warn_once transition and the typos Josh
> pointed out)
>
> [ ... snip ... ]
>> +static const char *l1tf_vmx_states[] = {
>> + [VMENTER_L1D_FLUSH_NEVER] = "vulnerable",
>> + [VMENTER_L1D_FLUSH_COND] = "mostly protected",
>> + [VMENTER_L1D_FLUSH_ALWAYS] = "fully protected"
>
> I somehow don't like the "mostly protected" string :)
I thought the same thing. It's going to result in lots of bad advice in
random forums and people being confused or whatnot.
> How about
>
> [VMENTER_L1D_FLUSH_NEVER] = "vulnerable",
> [VMENTER_L1D_FLUSH_COND] = "conditional flushes",
> [VMENTER_L1D_FLUSH_ALWAYS] = "flushes"
Why not just say "conditional L1D cache flush" or "L1D cache flushes".
Jon.
--
Computer Architect | Sent from my Fedora powered laptop
next prev parent reply other threads:[~2018-07-09 0:33 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-08 12:52 [patch 0/2] Command line and documentation 0 Thomas Gleixner
2018-07-08 12:52 ` [patch 1/2] Command line and documentation 1 Thomas Gleixner
2018-07-08 14:00 ` [MODERATED] " Josh Poimboeuf
2018-07-08 14:13 ` Thomas Gleixner
2018-07-08 15:21 ` [MODERATED] " Josh Poimboeuf
2018-07-09 7:07 ` Thomas Gleixner
2018-07-09 13:14 ` Thomas Gleixner
2018-07-09 13:21 ` [MODERATED] " Jiri Kosina
2018-07-09 13:25 ` Jiri Kosina
2018-07-09 15:32 ` Josh Poimboeuf
2018-07-09 15:40 ` Thomas Gleixner
2018-07-09 15:44 ` [MODERATED] " Jiri Kosina
2018-07-08 20:32 ` Jiri Kosina
2018-07-09 0:33 ` Jon Masters [this message]
2018-07-09 10:26 ` Ingo Molnar
2018-07-09 21:45 ` Andi Kleen
2018-07-09 22:08 ` Andi Kleen
2018-07-09 22:40 ` Jiri Kosina
2018-07-10 11:53 ` Thomas Gleixner
2018-07-08 12:52 ` [patch 2/2] Command line and documentation 2 Thomas Gleixner
2018-07-08 14:40 ` [MODERATED] " Andrew Cooper
2018-07-09 7:05 ` Thomas Gleixner
2018-07-08 15:40 ` [MODERATED] " Josh Poimboeuf
2018-07-09 11:04 ` Ingo Molnar
2018-07-09 11:08 ` Jiri Kosina
2018-07-09 11:47 ` Ingo Molnar
2018-07-09 15:18 ` Thomas Gleixner
2018-07-09 22:07 ` [MODERATED] " Andi Kleen
2018-07-09 23:00 ` Josh Poimboeuf
2018-07-09 23:11 ` Andi Kleen
2018-07-09 23:45 ` Linus Torvalds
2018-07-10 2:44 ` Josh Poimboeuf
2018-07-10 5:57 ` Jiri Kosina
2018-07-10 6:22 ` Jiri Kosina
2018-07-10 17:46 ` Linus Torvalds
2018-07-10 21:22 ` Thomas Gleixner
2018-07-10 21:30 ` [MODERATED] " Linus Torvalds
2018-07-10 21:53 ` Linus Torvalds
2018-07-10 22:27 ` Thomas Gleixner
2018-07-10 22:37 ` [MODERATED] " Linus Torvalds
2018-07-10 22:42 ` Linus Torvalds
2018-07-10 22:50 ` Josh Poimboeuf
2018-07-11 13:56 ` Jon Masters
2018-07-11 14:48 ` Josh Poimboeuf
2018-07-10 22:20 ` Thomas Gleixner
2018-07-10 22:35 ` [MODERATED] " Linus Torvalds
2018-07-10 7:41 ` Thomas Gleixner
2018-07-10 8:44 ` [MODERATED] " Jiri Kosina
2018-07-10 10:32 ` Jiri Kosina
2018-07-10 22:57 ` Josh Poimboeuf
2018-07-10 19:36 ` Thomas Gleixner
2018-07-11 14:03 ` [MODERATED] " Jon Masters
2018-07-08 13:11 ` [patch 0/2] Command line and documentation 0 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7bfed24-ca0e-54a4-a355-c9c694ea7250@redhat.com \
--to=jcm@redhat.com \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).