From: Thomas Gleixner <tglx@linutronix.de>
To: speck@linutronix.de
Subject: Re: [PATCH v2 5/8] kvm: handle host mode irqs 5
Date: Wed, 1 Aug 2018 08:54:36 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1808010852320.1713@nanos.tec.linutronix.de> (raw)
In-Reply-To: <87r2jizkds.fsf_-_@suse.de>
On Wed, 1 Aug 2018, speck for Nicolai Stange wrote:
> speck for Peter Zijlstra <speck@linutronix.de> writes:
>
> > On Fri, Jul 27, 2018 at 01:22:16PM +0200, speck for Nicolai Stange wrote:
> >> --- a/arch/x86/include/asm/hardirq.h
> >> +++ b/arch/x86/include/asm/hardirq.h
> >> @@ -7,6 +7,9 @@
> >>
> >> typedef struct {
> >> u16 __softirq_pending;
> >> +#if IS_ENABLED(CONFIG_KVM_INTEL)
> >> + bool kvm_cpu_l1tf_flush_l1d;
> >> +#endif
> >
> > NAK on using _Bool in a composite type.
> >
>
> Do I get it right that you'd prefer a bitfield?
>
> If so, I chose a bool here because updating a bitfield would
> involve a rmw operation and we might want to make NMIs set that flag
> opportunistically in a later patch.
>
> This series ignores NMIs for simplicity, because those issued after
> local_irq_disable() and before VMENTER would still get missed.
>
> Or did I miss your point completely?
Use an explicit type, because bool storage size is implementation
defined. It's a byte on x86, but in general we avoid it. So just use an u16
or such which avoids the rmw as well.
Thanks.
tglx
next prev parent reply other threads:[~2018-08-01 6:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 18:40 [MODERATED] [PATCH v2 0/8] kvm: handle host mode irqs 0 Nicolai Stange
2018-07-21 20:16 ` [MODERATED] [PATCH v2 1/8] kvm: handle host mode irqs 1 Nicolai Stange
2018-07-21 20:25 ` [MODERATED] [PATCH v2 2/8] kvm: handle host mode irqs 2 Nicolai Stange
2018-07-21 20:35 ` [MODERATED] [PATCH v2 3/8] kvm: handle host mode irqs 3 Nicolai Stange
2018-07-22 11:38 ` [MODERATED] [PATCH v2 8/8] kvm: handle host mode irqs 8 Nicolai Stange
2018-07-27 10:46 ` [MODERATED] [PATCH v2 4/8] kvm: handle host mode irqs 4 Nicolai Stange
2018-07-30 11:53 ` [MODERATED] " Paolo Bonzini
2018-07-27 11:22 ` [MODERATED] [PATCH v2 5/8] kvm: handle host mode irqs 5 Nicolai Stange
2018-07-30 11:53 ` [MODERATED] " Paolo Bonzini
2018-07-30 12:59 ` Peter Zijlstra
2018-08-01 6:11 ` Nicolai Stange
2018-08-01 6:12 ` [MODERATED] [AUTOREPLY] " Josh Poimboeuf
2018-08-01 6:54 ` Thomas Gleixner [this message]
2018-07-29 10:15 ` [MODERATED] [PATCH v2 6/8] kvm: handle host mode irqs 6 Nicolai Stange
2018-07-29 11:06 ` [MODERATED] [PATCH v2 7/8] kvm: handle host mode irqs 7 Nicolai Stange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1808010852320.1713@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).