From: Thomas Gleixner <tglx@linutronix.de>
To: speck@linutronix.de
Subject: Re: [PATCH] Linux patch
Date: Sun, 15 Jul 2018 11:32:28 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1807151131310.2644@nanos.tec.linutronix.de> (raw)
In-Reply-To: <nycvar.YFH.7.76.1807142154130.997@cbobk.fhfr.pm>
On Sat, 14 Jul 2018, speck for Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
> Subject: [PATCH] x86/speculation/l1tf: Unbreak !__HAVE_ARCH_PFN_MODIFY_ALLOWED architectures
>
> pfn_modify_allowed() and arch_has_pfn_modify_check() are outside of the
> !__ASSEMBLY__ section in include/asm-generic/pgtable.h, which confuses
> assembler on archs that don't have __HAVE_ARCH_PFN_MODIFY_ALLOWED (e.g.
> ia64) and breaks build:
>
> include/asm-generic/pgtable.h: Assembler messages:
> include/asm-generic/pgtable.h:538: Error: Unknown opcode `static inline bool pfn_modify_allowed(unsigned long pfn,pgprot_t prot)'
> include/asm-generic/pgtable.h:540: Error: Unknown opcode `return true'
> include/asm-generic/pgtable.h:543: Error: Unknown opcode `static inline bool arch_has_pfn_modify_check(void)'
> include/asm-generic/pgtable.h:545: Error: Unknown opcode `return false'
> arch/ia64/kernel/entry.S:69: Error: `mov' does not fit into bundle
>
> Move those two static inlines into the !__ASSEMBLY__ section so that they
> don't confuse the asm build pass.
>
> Fixes: 42e4089c7890 ("x86/speculation/l1tf: Disallow non privileged high MMIO PROT_NONE mappings")
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Applied to all branches.
Thanks,
tglx
prev parent reply other threads:[~2018-07-15 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-14 19:56 [MODERATED] [PATCH] Linux patch Jiri Kosina
2018-07-15 9:32 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1807151131310.2644@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).