From: Thomas Gleixner <tglx@linutronix.de>
To: speck@linutronix.de
Subject: Re: [PATCH] cpu/hotplug: SMT control knobs
Date: Tue, 29 May 2018 17:01:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1805291700580.1685@nanos.tec.linutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1805291648190.1685@nanos.tec.linutronix.de>
On Tue, 29 May 2018, speck for Thomas Gleixner wrote:
> On Tue, 29 May 2018, speck for Peter Zijlstra wrote:
> > + if (cpumask_weight(cpu_smt_mask(cpu)) > 1)
> > + static_branch_enable_cpuslocked(&sched_smt_present);
>
> This triggers the WARN_ON_ONCE() in static_key_enable() when the next
> sibling is onlined.... So this wants to be:
>
> if (!static_branch_likely(&sched_smt_present) &&
> cpumask_weight(cpu_smt_mask(cpu)) > 1)
> static_branch_enable_cpuslocked(&sched_smt_present);
>
> or something like that.
Ignore me. Misread the code ....
prev parent reply other threads:[~2018-05-29 15:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 22:08 [PATCH] cpu/hotplug: SMT control knobs Thomas Gleixner
2018-05-25 23:01 ` [MODERATED] " Andi Kleen
2018-05-26 6:58 ` Thomas Gleixner
2018-05-28 20:59 ` [MODERATED] " Jiri Kosina
2018-05-29 7:17 ` Peter Zijlstra
2018-05-29 7:54 ` Thomas Gleixner
2018-05-29 9:29 ` [MODERATED] " Peter Zijlstra
2018-05-29 9:59 ` Thomas Gleixner
2018-05-29 10:48 ` [MODERATED] " Peter Zijlstra
2018-05-29 12:58 ` Thomas Gleixner
2018-05-29 9:23 ` [MODERATED] " Peter Zijlstra
2018-05-29 14:53 ` Thomas Gleixner
2018-05-29 15:01 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1805291700580.1685@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).