From: Thomas Gleixner <tglx@linutronix.de>
To: speck@linutronix.de
Subject: Re: [PATCH 2/3] V5 more sampling fun 2
Date: Thu, 09 Apr 2020 01:21:22 +0200 [thread overview]
Message-ID: <87zhblpnrh.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200408203320.GB136636@mtg-dev.jf.intel.com>
Mark,
speck for mark gross <speck@linutronix.de> writes:
> On Tue, Apr 07, 2020 at 05:17:44PM +0200, speck for Thomas Gleixner wrote:
>> Mark,
>>
>> speck for mark gross <speck@linutronix.de> writes:
>> > +
>> > +static bool __init cpu_matches(unsigned long which, const struct x86_cpu_id *table)
>> > {
>> > - const struct x86_cpu_id *m = x86_match_cpu(cpu_vuln_whitelist);
>> > + const struct x86_cpu_id *m = x86_match_cpu(table);
>>
>> Can this and the fixup of the caller please be in a separate patch?
>
> Sure but, as a stand alown patch (outside the context of the srbds changes)
> making the x86_cpu_id pased by pointer instead of a hard coded global is a bit
> un-motivated. Is it ok of I keep it as part of the SRBDS patchset and not
> post it separately to lkml?
Of course it's part of ther SRBDS patch set, but it's way simpler to
review than this all in one combo change.
Thanks,
tglx
prev parent reply other threads:[~2020-04-08 23:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 17:52 [MODERATED] [PATCH 0/3] V5 more sampling fun 0 mark gross
2020-01-16 22:16 ` [MODERATED] [PATCH 2/3] V5 more sampling fun 2 mark gross
2020-01-30 19:12 ` [MODERATED] [PATCH 3/3] V5 more sampling fun 3 mark gross
2020-03-17 0:56 ` [MODERATED] [PATCH 1/3] V5 more sampling fun 1 mark gross
[not found] ` <5e8b7166.1c69fb81.4c99a.3619SMTPIN_ADDED_BROKEN@mx.google.com>
2020-04-06 18:31 ` [MODERATED] " Kees Cook
[not found] ` <5e8b71d8.1c69fb81.64075.43abSMTPIN_ADDED_BROKEN@mx.google.com>
2020-04-06 18:34 ` [MODERATED] Re: [PATCH 2/3] V5 more sampling fun 2 Kees Cook
2020-04-06 18:37 ` Greg KH
2020-04-06 20:56 ` mark gross
2020-04-06 22:14 ` Luck, Tony
2020-04-07 7:51 ` Greg KH
2020-04-06 18:52 ` mark gross
[not found] ` <5e8b71af.1c69fb81.d8b8.ac6bSMTPIN_ADDED_BROKEN@mx.google.com>
2020-04-06 18:34 ` [MODERATED] Re: [PATCH 3/3] V5 more sampling fun 3 Kees Cook
2020-04-06 22:07 ` [MODERATED] Re: [PATCH 2/3] V5 more sampling fun 2 Josh Poimboeuf
2020-04-07 0:34 ` mark gross
2020-04-07 12:39 ` Josh Poimboeuf
2020-04-08 20:26 ` mark gross
2020-04-08 22:14 ` mark gross
2020-04-08 22:58 ` mark gross
2020-04-07 15:17 ` Thomas Gleixner
2020-04-08 20:33 ` [MODERATED] " mark gross
2020-04-08 23:21 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhblpnrh.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).