From: Andi Kleen <andi@firstfloor.org>
To: speck@linutronix.de
Cc: Andi Kleen <ak@linux.intel.com>
Subject: [MODERATED] [PATCH 1/4] INVERTv2 1
Date: Tue, 7 Aug 2018 15:09:36 -0700 [thread overview]
Message-ID: <4c5dbc75464405ab865fe7a94eaff41c389e315b.1533679665.git.ak@linux.intel.com> (raw)
In-Reply-To: <cover.1533597855.git.ak@linux.intel.com>
In-Reply-To: <cover.1533679665.git.ak@linux.intel.com>
For kernel mappings PAGE_PROTNONE is not necessarily set for
non present mapping. To enable PTE inversion for those mappings
enable it for any non present mapping, not just prot_none.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
v2: Actually use correct check (Linus)
---
arch/x86/include/asm/pgtable-invert.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/pgtable-invert.h b/arch/x86/include/asm/pgtable-invert.h
index 177564187fc0..6ceb0cd968e3 100644
--- a/arch/x86/include/asm/pgtable-invert.h
+++ b/arch/x86/include/asm/pgtable-invert.h
@@ -6,7 +6,7 @@
static inline bool __pte_needs_invert(u64 val)
{
- return (val & (_PAGE_PRESENT|_PAGE_PROTNONE)) == _PAGE_PROTNONE;
+ return (val & _PAGE_PRESENT) == 0;
}
/* Get a mask to xor with the page table entry to get the correct pfn. */
--
2.17.1
next prev parent reply other threads:[~2018-08-07 22:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 23:29 [MODERATED] [PATCH 0/4] INVERTv1 2 Andi Kleen
2018-08-06 23:29 ` [MODERATED] [PATCH 1/4] INVERTv1 1 Andi Kleen
2018-08-06 23:36 ` [MODERATED] " Linus Torvalds
2018-08-07 0:15 ` Andi Kleen
2018-08-06 23:29 ` [MODERATED] [PATCH 2/4] INVERTv1 4 Andi Kleen
2018-08-06 23:29 ` [MODERATED] [PATCH 3/4] INVERTv1 3 Andi Kleen
2018-08-06 23:29 ` [MODERATED] [PATCH 4/4] INVERTv1 0 Andi Kleen
[not found] ` <cover.1533679665.git.ak@linux.intel.com>
2018-08-07 22:09 ` Andi Kleen [this message]
2018-08-07 22:09 ` [MODERATED] [PATCH 2/4] INVERTv2 4 Andi Kleen
2018-08-07 22:09 ` [MODERATED] [PATCH 3/4] INVERTv2 3 Andi Kleen
2018-08-08 7:23 ` Thomas Gleixner
2018-08-08 19:31 ` [MODERATED] " Andi Kleen
2018-08-08 19:43 ` Thomas Gleixner
2018-08-07 22:09 ` [MODERATED] [PATCH 4/4] INVERTv2 0 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c5dbc75464405ab865fe7a94eaff41c389e315b.1533679665.git.ak@linux.intel.com \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).