From: Paolo Bonzini <pbonzini@redhat.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: ***UNCHECKED*** Re: [PATCH v7 0/5] NX 0
Date: Thu, 31 Oct 2019 23:13:02 +0100 [thread overview]
Message-ID: <36d392a0-f4af-9038-6be2-83b0204c2dfd@redhat.com> (raw)
In-Reply-To: <20191031210054.GG19327@elm>
[-- Attachment #1: Type: text/plain, Size: 2520 bytes --]
On 31/10/19 22:00, speck for Tyler Hicks wrote:
>> diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
>> index 0fccd8c0312e..86f531fea9d0 100644
>> --- a/drivers/base/cpu.c
>> +++ b/drivers/base/cpu.c
>
> I hate to make this thread more of a mess than it already is but I
> noticed that you dropped a hunk that shouldn't have been dropped. The
> following needs to be applied on top of this patch:
Thank you Tyler. Let me just pick Thomas's bundles and send the final
version.
Paolo
> diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
> index 86f531fea9d0..7fbc022a235b 100644
> --- a/drivers/base/cpu.c
> +++ b/drivers/base/cpu.c
> @@ -561,6 +561,12 @@ ssize_t __weak cpu_show_tsx_async_abort(struct device *dev,
> return sprintf(buf, "Not affected\n");
> }
>
> +ssize_t __weak cpu_show_itlb_multihit(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + return sprintf(buf, "Not affected\n");
> +}
> +
> static DEVICE_ATTR(meltdown, 0444, cpu_show_meltdown, NULL);
> static DEVICE_ATTR(spectre_v1, 0444, cpu_show_spectre_v1, NULL);
> static DEVICE_ATTR(spectre_v2, 0444, cpu_show_spectre_v2, NULL);
>
>> @@ -568,6 +568,7 @@ static DEVICE_ATTR(spec_store_bypass, 0444, cpu_show_spec_store_bypass, NULL);
>> static DEVICE_ATTR(l1tf, 0444, cpu_show_l1tf, NULL);
>> static DEVICE_ATTR(mds, 0444, cpu_show_mds, NULL);
>> static DEVICE_ATTR(tsx_async_abort, 0444, cpu_show_tsx_async_abort, NULL);
>> +static DEVICE_ATTR(itlb_multihit, 0444, cpu_show_itlb_multihit, NULL);
>>
>> static struct attribute *cpu_root_vulnerabilities_attrs[] = {
>> &dev_attr_meltdown.attr,
>> @@ -577,6 +578,7 @@ static struct attribute *cpu_root_vulnerabilities_attrs[] = {
>> &dev_attr_l1tf.attr,
>> &dev_attr_mds.attr,
>> &dev_attr_tsx_async_abort.attr,
>> + &dev_attr_itlb_multihit.attr,
>> NULL
>> };
>>
>> diff --git a/include/linux/cpu.h b/include/linux/cpu.h
>> index f35369f79771..2a093434e975 100644
>> --- a/include/linux/cpu.h
>> +++ b/include/linux/cpu.h
>> @@ -62,6 +62,8 @@ extern ssize_t cpu_show_mds(struct device *dev,
>> extern ssize_t cpu_show_tsx_async_abort(struct device *dev,
>> struct device_attribute *attr,
>> char *buf);
>> +extern ssize_t cpu_show_itlb_multihit(struct device *dev,
>> + struct device_attribute *attr, char *buf);
>>
>> extern __printf(4, 5)
>> struct device *cpu_device_create(struct device *parent, void *drvdata,
>> --
>> 2.16.4
>>
prev parent reply other threads:[~2019-10-31 22:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 7:34 [MODERATED] [PATCH v7 0/5] NX 0 Paolo Bonzini
2019-10-24 7:34 ` [MODERATED] [PATCH v7 1/5] NX 1 Paolo Bonzini
2019-10-24 8:57 ` [MODERATED] " Paolo Bonzini
2019-10-24 14:21 ` Tyler Hicks
2019-10-24 14:25 ` Paolo Bonzini
2019-10-24 15:01 ` Tyler Hicks
2019-10-24 7:34 ` [MODERATED] [PATCH v7 2/5] NX 2 Paolo Bonzini
2019-10-24 7:34 ` [MODERATED] [PATCH v7 3/5] NX 3 Paolo Bonzini
2019-10-24 7:34 ` [MODERATED] [PATCH v7 4/5] NX 4 Paolo Bonzini
2019-10-24 7:34 ` [MODERATED] [PATCH v7 5/5] NX 5 Paolo Bonzini
2019-10-28 12:08 ` [PATCH v7 0/5] NX 0 Thomas Gleixner
2019-10-28 16:02 ` [MODERATED] Re: ***UNCHECKED*** " Joerg Roedel
2019-10-29 8:51 ` Thomas Gleixner
2019-10-29 9:39 ` [MODERATED] Re: ***UNCHECKED*** " Joerg Roedel
2019-10-29 11:00 ` Thomas Gleixner
2019-10-29 12:31 ` [MODERATED] Re: ***UNCHECKED*** " Joerg Roedel
2019-10-29 15:35 ` Thomas Gleixner
2019-10-29 15:42 ` [MODERATED] Re: ***UNCHECKED*** " Joerg Roedel
2019-10-29 16:50 ` Paolo Bonzini
2019-10-31 21:00 ` [MODERATED] Re: ***UNCHECKED*** " Tyler Hicks
2019-10-31 22:13 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36d392a0-f4af-9038-6be2-83b0204c2dfd@redhat.com \
--to=pbonzini@redhat.com \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).