Historical speck list archives
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: qemu patch for mb_clear
Date: Fri, 1 Mar 2019 09:11:14 -0600	[thread overview]
Message-ID: <20190301151114.sqo6kb5dbsp3ilxh@treble> (raw)
In-Reply-To: <20190301143729.r3onrecxplx3pvly@treble>

On Fri, Mar 01, 2019 at 08:37:29AM -0600, Josh Poimboeuf wrote:
> On Thu, Dec 20, 2018 at 04:31:01PM -0800, speck for Andi Kleen wrote:
> > 
> > For reference here is the qemu patch needed for using MB_CLEAR in a KVM
> > guest.
> > 
> > -Andi
> > 
> > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > index 677a3bd5fb25..77a1149e4bb3 100644
> > --- a/target/i386/cpu.c
> > +++ b/target/i386/cpu.c
> > @@ -1038,7 +1038,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
> >          .feat_names = {
> >              NULL, NULL, "avx512-4vnniw", "avx512-4fmaps",
> >              NULL, NULL, NULL, NULL,
> > -            NULL, NULL, NULL, NULL,
> > +            NULL, NULL, "mbclear", NULL,
> >              NULL, NULL, NULL, NULL,
> >              NULL, NULL, "pconfig", NULL,
> >              NULL, NULL, NULL, NULL,
> 
> Is this still the latest version of the qemu patch?  I assume this needs
> to be updated to MD_CLEAR.

Also:

- A patch title and description would be helpful.

- Calling it "md-clear" (with the dash) would be preferable, as people
  constantly get confused when the names differ (and apparently qemu
  uses dashes instead of underscores).

-- 
Josh

      reply	other threads:[~2019-03-01 15:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-21  0:31 [MODERATED] qemu patch for mb_clear Andi Kleen
2019-01-09 17:09 ` [MODERATED] " Konrad Rzeszutek Wilk
2019-01-09 17:33   ` Andi Kleen
2019-01-09 21:44   ` Paolo Bonzini
2019-01-09 21:55     ` Andi Kleen
2019-01-09 22:37       ` Paolo Bonzini
2019-03-01 14:37 ` Josh Poimboeuf
2019-03-01 15:11   ` Josh Poimboeuf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190301151114.sqo6kb5dbsp3ilxh@treble \
    --to=jpoimboe@redhat.com \
    --cc=speck@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).