From: Josh Poimboeuf <jpoimboe@redhat.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [PATCH v4 2/8] [PATCH v4 2/8] Linux Patch #2
Date: Sun, 1 Jul 2018 11:14:29 -0500 [thread overview]
Message-ID: <20180701161429.cjtgofoepigrokgy@treble> (raw)
In-Reply-To: <20180623135445.576988756@localhost.localdomain>
On Sat, Jun 23, 2018 at 09:54:16AM -0400, speck for konrad.wilk_at_oracle.com wrote:
> @@ -7392,7 +7447,11 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
>
> preempt_disable();
>
> + vcpu->arch.flush_cache_req = vcpu->arch.vcpu_unconfined;
> kvm_x86_ops->prepare_guest_switch(vcpu);
> + vcpu->arch.vcpu_unconfined = false;
> + if (vcpu->arch.flush_cache_req)
> + vcpu->stat.l1d_flush++;
As Boris said, I don't see the need for the two different variables
which basically track the same thing. And why is the stat updated in a
separate location from the actual flush?
--
Josh
prev parent reply other threads:[~2018-07-01 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 13:54 [MODERATED] [PATCH v4 2/8] [PATCH v4 2/8] Linux Patch #2 konrad.wilk
2018-06-27 10:20 ` Thomas Gleixner
2018-06-27 15:54 ` [MODERATED] " Borislav Petkov
2018-06-27 16:21 ` Josh Poimboeuf
2018-06-28 7:25 ` Thomas Gleixner
2018-06-28 10:44 ` Thomas Gleixner
2018-06-28 15:13 ` Thomas Gleixner
2018-06-29 12:31 ` [MODERATED] " Paolo Bonzini
2018-07-01 16:14 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180701161429.cjtgofoepigrokgy@treble \
--to=jpoimboe@redhat.com \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).