From: Borislav Petkov <bp@suse.de>
To: speck@linutronix.de
Subject: [MODERATED] Re: [PATCH v4 4/8] [PATCH v4 4/8] Linux Patch #4
Date: Wed, 27 Jun 2018 18:39:15 +0200 [thread overview]
Message-ID: <20180627163915.GI24227@zn.tnic> (raw)
In-Reply-To: <20180623135445.718850513@localhost.localdomain>
On Sat, Jun 23, 2018 at 09:54:18AM -0400, speck for konrad.wilk_at_oracle.com wrote:
> x86/KVM/VMX: Split the VMX MSR LOAD structures to have an host/guest numbers.
>
> There is no semantic change but with this change we can allow an
> unbalanced amount of MSRs to be loaded on VMEXIT and VMENTER.
>
> That is the number of MSRs to save or restore on VMEXIT or VMENTER may
> be different.
This commit message could use some big picture blurb for outsiders like
me to explain why we're doing this...
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> arch/x86/kvm/vmx.c | 65 +++++++++++++++++++++++++++++-------------------------
> 1 file changed, 35 insertions(+), 30 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index a51418429165..3649bf3b3b82 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -763,6 +763,11 @@ static inline int pi_test_sn(struct pi_desc *pi_desc)
> (unsigned long *)&pi_desc->control);
> }
>
> +struct vmx_msrs {
> + unsigned nr;
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#36: FILE: arch/x86/kvm/vmx.c:767:
+ unsigned nr;
Even checkpatch is sometimes right. :)
> + struct vmx_msr_entry val[NR_AUTOLOAD_MSRS];
> +};
> +
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
prev parent reply other threads:[~2018-06-27 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 13:54 [MODERATED] [PATCH v4 4/8] [PATCH v4 4/8] Linux Patch #4 konrad.wilk
2018-06-27 16:39 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627163915.GI24227@zn.tnic \
--to=bp@suse.de \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).