From: Josh Poimboeuf <jpoimboe@redhat.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [patch V4 02/13] x86/smp: Provide topology_is_primary_thread()
Date: Wed, 27 Jun 2018 11:20:31 -0500 [thread overview]
Message-ID: <20180627162031.movkffhvfckhbggl@treble> (raw)
In-Reply-To: <alpine.DEB.2.21.1806271753360.17787@nanos.tec.linutronix.de>
On Wed, Jun 27, 2018 at 05:54:04PM +0200, speck for Thomas Gleixner wrote:
> On Wed, 27 Jun 2018, speck for Josh Poimboeuf wrote:
>
> > On Wed, Jun 20, 2018 at 10:19:09PM +0200, speck for Thomas Gleixner wrote:
> > > --- a/arch/x86/include/asm/topology.h
> > > +++ b/arch/x86/include/asm/topology.h
> > > @@ -123,13 +123,15 @@ static inline int topology_max_smt_threa
> > > }
> > >
> > > int topology_update_package_map(unsigned int apicid, unsigned int cpu);
> > > -extern int topology_phys_to_logical_pkg(unsigned int pkg);
> > > +int topology_phys_to_logical_pkg(unsigned int pkg);
> > > +bool topology_is_primary_thread(unsigned int cpu);
> > > #else
> > > #define topology_max_packages() (1)
> > > static inline int
> > > topology_update_package_map(unsigned int apicid, unsigned int cpu) { return 0; }
> > > static inline int topology_phys_to_logical_pkg(unsigned int pkg) { return 0; }
> > > static inline int topology_max_smt_threads(void) { return 1; }
> > > +static inline bool topology_is_primary_thread(unsigned int cpu) { return true; ]
> >
> > Longman found a typo: "]" at the end of the line
>
> In the patch but not in the repo...
Where is the repo?
--
Josh
next prev parent reply other threads:[~2018-06-27 16:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 20:19 [patch V4 00/13] SMT control knobs Thomas Gleixner
2018-06-20 20:19 ` [patch V4 01/13] sched/smt: Update sched_smt_present at runtime Thomas Gleixner
2018-06-20 20:19 ` [patch V4 02/13] x86/smp: Provide topology_is_primary_thread() Thomas Gleixner
2018-06-27 13:56 ` [MODERATED] " Josh Poimboeuf
2018-06-27 15:54 ` Thomas Gleixner
2018-06-27 16:20 ` Josh Poimboeuf [this message]
2018-06-27 16:52 ` Thomas Gleixner
2018-06-20 20:19 ` [patch V4 03/13] cpu/hotplug: Make bringup/teardown of smp threads symmetric Thomas Gleixner
2018-06-20 20:19 ` [patch V4 04/13] cpu/hotplug: Split do_cpu_down() Thomas Gleixner
2018-06-20 20:19 ` [patch V4 05/13] cpu/hotplug: Provide knobs to control SMT Thomas Gleixner
2018-06-20 23:05 ` [MODERATED] " Greg KH
2018-06-21 6:08 ` Thomas Gleixner
2018-06-20 20:19 ` [patch V4 06/13] x86/cpu: Remove the pointless CPU printout Thomas Gleixner
2018-06-20 20:19 ` [patch V4 07/13] x86/cpu/AMD: Remove the pointless detect_ht() call Thomas Gleixner
2018-06-20 20:19 ` [patch V4 08/13] x86/cpu/common: Provide detect_ht_early() Thomas Gleixner
2018-06-20 20:19 ` [patch V4 09/13] x86/cpu/topology: Provide detect_extended_topology_early() Thomas Gleixner
2018-06-20 20:19 ` [patch V4 10/13] x86/cpu/intel: Evaluate smp_num_siblings early Thomas Gleixner
2018-06-20 20:19 ` [patch V4 11/13] x86/CPU/AMD: Do not check CPUID max ext level before parsing SMP info Thomas Gleixner
2018-06-20 20:19 ` [patch V4 12/13] x86/cpu/AMD: Evaluate smp_num_siblings early Thomas Gleixner
2018-06-20 20:19 ` [patch V4 13/13] x86/apic: Ignore secondary threads if nosmt=force Thomas Gleixner
2018-06-20 21:44 ` [MODERATED] " Linus Torvalds
2018-06-28 22:13 ` Dave Hansen
2018-06-28 22:19 ` Andrew Cooper
2018-06-28 22:23 ` Luck, Tony
2018-06-28 22:29 ` Andrew Cooper
2018-06-29 8:26 ` [MODERATED] " Borislav Petkov
2018-06-29 17:01 ` Luck, Tony
2018-06-29 17:08 ` Linus Torvalds
2018-06-29 18:36 ` Thomas Gleixner
2018-06-29 8:50 ` Thomas Gleixner
2018-06-29 16:48 ` [MODERATED] " Dave Hansen
2018-06-20 20:53 ` [patch V4 00/13] SMT control knobs Thomas Gleixner
2018-06-21 11:52 ` [MODERATED] " Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627162031.movkffhvfckhbggl@treble \
--to=jpoimboe@redhat.com \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).