From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@kotori.zaitcev.us>
Cc: hail-devel@vger.kernel.org
Subject: Re: [patch hail 1/1] Plug leak in hstor_parse_key
Date: Wed, 19 Oct 2011 00:18:59 -0400 [thread overview]
Message-ID: <4E9E4FB3.1020808@garzik.org> (raw)
In-Reply-To: <20111014113415.57bbf8de@lembas.zaitcev.lan>
On 10/14/2011 01:34 PM, Pete Zaitcev wrote:
> Signed-off-by: Pete Zaitcev<zaitcev@kotori.zaitcev.us>
>
> ---
> lib/hstor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/hstor.c b/lib/hstor.c
> index cb9c4da..5ce9b76 100644
> --- a/lib/hstor.c
> +++ b/lib/hstor.c
> @@ -761,7 +761,7 @@ void hstor_free_keylist(struct hstor_keylist *keylist)
> static void hstor_parse_key(xmlDocPtr doc, xmlNode *node,
> struct hstor_keylist *keylist)
> {
> - struct hstor_object *obj = calloc(1, sizeof(*obj));
> + struct hstor_object *obj;
> xmlChar *xs;
good catch... applied
prev parent reply other threads:[~2011-10-19 4:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 17:34 [patch hail 1/1] Plug leak in hstor_parse_key Pete Zaitcev
2011-10-19 4:18 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9E4FB3.1020808@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@kotori.zaitcev.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).