From: Jeff Garzik <jeff@garzik.org>
To: Jim Meyering <jim@meyering.net>
Cc: Project Hail <hail-devel@vger.kernel.org>
Subject: Re: [PATCH tabled 1/2] server/config.c: don't dereference NULL on OOM
Date: Fri, 24 Sep 2010 13:50:44 -0400 [thread overview]
Message-ID: <4C9CE4F4.302@garzik.org> (raw)
In-Reply-To: <87k4mbnik3.fsf@meyering.net>
On 09/24/2010 01:43 PM, Jim Meyering wrote:
> Jeff Garzik wrote:
>> On 09/24/2010 07:32 AM, Jim Meyering wrote:
>>> You can pull from the "oom" branch here:
>>> git://git.infradead.org/users/meyering/tabled.git
>>
>> Got nearly everything perfect. Need one more minor yet important
>> change. As described in doc/contributions.txt, every changeset MUST
>> have a Signed-off-by line at the end of a changeset's description.
>>
>> I was able to pull and build just fine, so your git repo setup and
>> push appears correct.
>>
>> Also, in your pull request, please put the branch immediately
>> following the repo URL on the same line, for easier cut-n-paste.
>> Here's how Linus requests his pull-requests to look:
>
> Ok. I've added those pesky S.O.B lines with this:
>
> git filter-branch --msg-filter \
> 'cat&& printf "\nSigned-off-by: Jim Meyering<meyering@redhat.com>\n"' \
> HEAD~4..HEAD
>
> and pushed the result.
>
> Please pull from the 'oom' branch of
> git://git.infradead.org/users/meyering/tabled.git
pulled from you & pushed upstream, thanks!
next prev parent reply other threads:[~2010-09-24 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 8:43 [PATCH tabled 1/2] server/config.c: don't dereference NULL on OOM Jim Meyering
2010-09-23 18:57 ` Jeff Garzik
2010-09-23 19:19 ` Jeff Garzik
2010-09-23 19:35 ` Jeff Garzik
2010-09-24 11:32 ` Jim Meyering
2010-09-24 11:55 ` Jim Meyering
2010-09-24 17:24 ` Jeff Garzik
2010-09-24 17:43 ` Jim Meyering
2010-09-24 17:50 ` Jeff Garzik [this message]
2010-09-24 11:02 ` Jim Meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9CE4F4.302@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).