From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [hail patch 1/1] fix hstor crashes
Date: Wed, 07 Jul 2010 20:44:57 -0400 [thread overview]
Message-ID: <4C351F89.7030208@garzik.org> (raw)
In-Reply-To: <20100707182157.5fd492fd@lembas.zaitcev.lan>
On 07/07/2010 08:21 PM, Pete Zaitcev wrote:
> This patch addresses two bugs:
>
> - No parameters to search worked (because character '=' was missing,
> e.g. delim/ instead of delim=/), and also there were weird truncations
> because prefix can easily be longer than 32 characters.
>
> - If prefix is empty, xmlNodeListGetString returns NULL instead of "",
> thus segfault in strdup. This is not easy to accomplish with Boto,
> but our own httpstor can do it.
>
> Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
>
> ---
> lib/hstor.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> This patch was actually tested on httpstor, I've not switched to hstor
> yet, but it seems to apply 100%. There's no sense in fixing httpstor,
> I'm going to delete it from tabled soon.
applied
Check out 'libhail-merge' branch of tabled.git, it should have already
fixed up the issues and the delete.
prev parent reply other threads:[~2010-07-08 0:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 0:21 [hail patch 1/1] fix hstor crashes Pete Zaitcev
2010-07-08 0:44 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C351F89.7030208@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).