From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [Patch 2/3] chcli cleanup: gcc warning
Date: Wed, 03 Mar 2010 06:45:41 -0500 [thread overview]
Message-ID: <4B8E4BE5.1050205@garzik.org> (raw)
In-Reply-To: <20100302194150.30eddb80@redhat.com>
On 03/02/2010 09:41 PM, Pete Zaitcev wrote:
> On Tue, 02 Mar 2010 21:18:24 -0500
> Jeff Garzik<jeff@garzik.org> wrote:
>
>> Note that your mailer is mangling patches via "quoted-printable":
>
> No, it does not. Look at this:
>
> [zaitcev@lembas ~]$ grep fstat Mail/inbox/*
> Mail/inbox/10891:# diffstat add_function.patch hub_revision_ACPI_modes.patch
> Mail/inbox/15830:- rc =3D fstat(fd,&stat);
> Mail/inbox/15830:+ rc =3D fstat(fd,&st);
> Mail/inbox/15833:- rc = fstat(fd,&stat);
> Mail/inbox/15833:+ rc = fstat(fd,&statb);
>
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: quoted-printable
>> [...]
>> =20
>> - rc =3D fstat(fd,&stat);
>> + rc =3D fstat(fd,&st);
>> if (rc) {
>
> Clearly, its your own message you are complaining about, not mine,
> because my patch changed the variable to 'statb' (and it's not
> corrupt, see above grep), while your patch changed to it to 'st'.
> "My mailer" did not even touch it. Heck, I did not even see that
> message (although I did a git pull to see if the "note" you promised
> was attached to the changelog).
I manually changed s/statb/st/ using vi directly on the Berkeley mbox
file. Don't get confused by that.
Ignore the variable name change and look at the quoted-printable
artifacts "=3D", "=20", etc...
Jeff
prev parent reply other threads:[~2010-03-03 11:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 2:08 [Patch 2/3] chcli cleanup: gcc warning Pete Zaitcev
2010-03-03 2:18 ` Jeff Garzik
2010-03-03 2:41 ` Pete Zaitcev
2010-03-03 11:45 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8E4BE5.1050205@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).