From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: [patch tabled 2/8] Comment storage.c
Date: Sun, 28 Nov 2010 18:39:51 -0700 [thread overview]
Message-ID: <20101128183951.705702a9@lembas.zaitcev.lan> (raw)
I have a vague memory that "It should be ok to return" meant something
related to the way our event dispatch worked, but I cannot recall any
details. Ergo, useless comment.
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
---
server/storage.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
commit 8c4bed7bd56a5bb2c3a654a494a6bb545f0d7db2
Author: Pete Zaitcev <zaitcev@yahoo.com>
Date: Thu Nov 11 15:46:59 2010 -0700
Update comments.
diff --git a/server/storage.c b/server/storage.c
index c472961..5c6e3a7 100644
--- a/server/storage.c
+++ b/server/storage.c
@@ -161,9 +161,6 @@ int stor_put_start(struct open_chunk *cep, void (*cb)(struct open_chunk *),
return 0;
}
-/*
- * It should be ok to return
- */
int stor_open_read(struct open_chunk *cep, void (*cb)(struct open_chunk *),
uint64_t key, uint64_t *psize)
{
@@ -379,6 +376,9 @@ int stor_obj_del(struct storage_node *stn, uint64_t key)
return rc;
}
+/*
+ * XXX WTF?! This accidentially tests a node instead of object! FIXME
+ */
bool stor_obj_test(struct open_chunk *cep, uint64_t key)
{
struct st_keylist *klist;
reply other threads:[~2010-11-29 1:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101128183951.705702a9@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).