From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Jim Meyering <jim@meyering.net>,
Project Hail <hail-devel@vger.kernel.org>
Subject: Re: [PATCH hail] lib/hstor.c: avoid an unconditional leak in append_qparam
Date: Mon, 27 Sep 2010 18:24:14 -0600 [thread overview]
Message-ID: <20100927182414.0540ffa9@lembas.zaitcev.lan> (raw)
In-Reply-To: <4CA0CC1C.8040407@garzik.org>
On Mon, 27 Sep 2010 12:53:48 -0400
Jeff Garzik <jeff@garzik.org> wrote:
> > - stmp = huri_field_escape(strdup(val), QUERY_ESCAPE_MASK);
> > + v = strdup(val);
> > + stmp = huri_field_escape(v, QUERY_ESCAPE_MASK);
> > str = g_string_append(str, stmp);
> > free(stmp);
> > + free(v);
>
> applied
I'm going to post a patch that undoes the damage. It's in testing.
-- Pete
prev parent reply other threads:[~2010-09-28 0:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 8:53 [PATCH hail] lib/hstor.c: avoid an unconditional leak in append_qparam Jim Meyering
2010-09-27 16:29 ` Pete Zaitcev
2010-09-27 17:05 ` Jim Meyering
2010-09-28 0:23 ` Jeff Garzik
2010-09-27 16:53 ` Jeff Garzik
2010-09-28 0:24 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927182414.0540ffa9@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).