From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: [hail patch 3/3] Use a constant like elsewhere
Date: Wed, 4 Aug 2010 17:13:43 -0600 [thread overview]
Message-ID: <20100804171343.4d58ea24@lembas.zaitcev.lan> (raw)
Actually a competent compiler should replace this strlen with a
constant expression, so a performance win is unlikely, but why
bother if we already have this constant and use it in similar cases?
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
---
lib/chunkdc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/chunkdc.c b/lib/chunkdc.c
index 3f1994e..13f5d36 100644
--- a/lib/chunkdc.c
+++ b/lib/chunkdc.c
@@ -139,9 +139,9 @@ static bool net_write(struct st_client *stc, const void *data, size_t datalen)
static bool resp_valid(const struct chunksrv_resp *resp)
{
- if (memcmp(resp->magic, CHUNKD_MAGIC, strlen(CHUNKD_MAGIC)))
+ if (memcmp(resp->magic, CHUNKD_MAGIC, CHD_MAGIC_SZ))
return false;
-
+
return true;
}
reply other threads:[~2010-08-04 23:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804171343.4d58ea24@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).