From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [tabled patch 2/4] fix the selection of chunk
Date: Tue, 25 May 2010 21:25:13 -0600 [thread overview]
Message-ID: <20100525212513.6bf932aa@redhat.com> (raw)
In-Reply-To: <4BFC52BB.7060509@garzik.org>
On Tue, 25 May 2010 18:44:11 -0400
Jeff Garzik <jeff@garzik.org> wrote:
> On 05/21/2010 10:19 PM, Pete Zaitcev wrote:
> > +static int object_node_select(int *nx, struct db_obj_ent *obj)
> > +{
> > + struct storage_node *stnode;
> > + if (stnode->up)
> > + return stnode;
> Did you compile or test this???
I suppose I deserved the tripple question mark for this. I tested it,
of course. The funny thing, everything is mapped below 4GB, way below
actually. As for warnings, I managed to miss them, because I started
running with -Wpointer-arith -Wsign-compare recently and that floods.
There's a lesson in it somewhere.
-- Pete
prev parent reply other threads:[~2010-05-26 3:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 2:19 [tabled patch 2/4] fix the selection of chunk Pete Zaitcev
2010-05-25 22:44 ` Jeff Garzik
2010-05-26 3:25 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525212513.6bf932aa@redhat.com \
--to=zaitcev@redhat.com \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).