From: Pete Zaitcev <zaitcev@redhat.com>
To: jeff@garzik.org
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: [Patch 2/3] chunkd: End-to-end verbosity v3
Date: Tue, 13 Apr 2010 14:30:41 -0600 [thread overview]
Message-ID: <20100413143041.08bd2732@redhat.com> (raw)
Signed-Off-By: Pete Zaitcev <zaitcev@redhat.com>
---
pkg/chunkd.sysconf | 2 +-
server/cldu.c | 3 ++-
server/server.c | 22 ++++++++++++++++------
3 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/pkg/chunkd.sysconf b/pkg/chunkd.sysconf
index 7272a0d..122b524 100644
--- a/pkg/chunkd.sysconf
+++ b/pkg/chunkd.sysconf
@@ -2,5 +2,5 @@
#
#example:
-#OPTS="--debug"
+#OPTS="--debug 1"
diff --git a/server/cldu.c b/server/cldu.c
index 51d01a3..b2d3388 100644
--- a/server/cldu.c
+++ b/server/cldu.c
@@ -319,7 +319,8 @@ static int cldu_set_cldc(struct cld_session *cs, int newactive)
hp->host, hp->port);
cs->nsess = ncld_sess_open(hp->host, hp->port, &error,
- cldu_sess_event, cs, "tabled", "tabled");
+ cldu_sess_event, cs, "tabled", "tabled",
+ &cldu_hail_log);
if (cs->nsess == NULL) {
if (error < 1000) {
applog(LOG_ERR, "ncld_sess_open(%s,%u) error: %s",
diff --git a/server/server.c b/server/server.c
index 69f3973..f367676 100644
--- a/server/server.c
+++ b/server/server.c
@@ -66,8 +66,8 @@ enum {
static struct argp_option options[] = {
{ "config", 'C', "FILE", 0,
"Read master configuration from FILE" },
- { "debug", 'D', NULL, 0,
- "Enable debug output" },
+ { "debug", 'D', "LEVEL", 0,
+ "Set debug output to LEVEL (0 = off, 2 = max)" },
{ "stderr", 'E', NULL, 0,
"Switch the log to standard error" },
{ "foreground", 'F', NULL, 0,
@@ -170,12 +170,24 @@ void applog(int prio, const char *fmt, ...)
static error_t parse_opt (int key, char *arg, struct argp_state *state)
{
+ int v;
+
switch(key) {
case 'C':
chunkd_srv.config = arg;
break;
case 'D':
- debugging = 1;
+ v = atoi(arg);
+ if (v < 0 || v > 2) {
+ fprintf(stderr, "invalid debug level: '%s'\n", arg);
+ argp_usage(state);
+ }
+ if (v >= 1)
+ debugging = 1;
+ if (v >= 2) {
+ cldu_hail_log.debug = true;
+ cldu_hail_log.verbose = true;
+ }
break;
case 'E':
use_syslog = false;
@@ -1736,9 +1748,7 @@ int main (int argc, char *argv[])
if (use_syslog)
openlog(PROGRAM_NAME, LOG_PID, LOG_LOCAL3);
if (debugging)
- applog(LOG_INFO, "Verbose debug output enabled");
-
- cldu_hail_log.verbose = debugging;
+ applog(LOG_INFO, "Debug output enabled");
g_thread_init(NULL);
chunkd_srv.bigmutex = g_mutex_new();
next reply other threads:[~2010-04-13 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 20:30 Pete Zaitcev [this message]
2010-04-14 4:35 ` [Patch 2/3] chunkd: End-to-end verbosity v3 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100413143041.08bd2732@redhat.com \
--to=zaitcev@redhat.com \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).