From: Oliver Steffen <osteffen@redhat.com>
To: Daniel Kiper <dkiper@net-space.pl>,
grub-devel@gnu.org, mate.kukri@canonical.com
Subject: Re: [PATCH] build: Include grub-core/extra_deps.lst in dist
Date: Thu, 22 Feb 2024 05:35:48 -0800 [thread overview]
Message-ID: <CA+bRGFoC2QmKGvRN6oyvtxVoboqQ-v-4v-mTnGxiF-aGw1a9Eg@mail.gmail.com> (raw)
In-Reply-To: <20231222141844.okcmcog7yw4ayp3g@tomti.i.net-space.pl>
Quoting Daniel Kiper (2023-12-22 15:18:44)
> On Thu, Dec 21, 2023 at 01:17:35AM -0600, Oskari Pirhonen wrote:
> > Fixes build failure due to the extra_deps.lst file not existing in the
> > tarball. Found while trying to package GRUB 2.12 for Gentoo.
> >
> > make[3]: *** No rule to make target '/var/tmp/portage/sys-boot/grub-2.12/work/grub-2.12/grub-core/extra_deps.lst', needed by 'syminfo.lst'. Stop.
> >
> > Fixes: 89fbe0cac (grub-core/Makefile.am: Make path to extra_deps.lst relative to $(top_srcdir)/grub-core)
> > Fixes: 154dcb1ae (build: Allow explicit module dependencies)
> >
> > Signed-off-by: Oskari Pirhonen <xxc3ncoredxx@gmail.com>
>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
>
> Daniel
>
I had assumed that this went in already.
I think this is OK if we want the simple solution.
For the more elaborate machinery see my patch I just sent.
Anyway,
Acked-by: Oliver Steffen <osteffen@redhat.com>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2024-02-22 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 7:17 [PATCH] build: Include grub-core/extra_deps.lst in dist Oskari Pirhonen
2023-12-21 9:12 ` Olaf Hering
2023-12-21 10:42 ` Oliver Steffen
2023-12-21 10:50 ` Olaf Hering
2023-12-21 11:07 ` Oliver Steffen
2023-12-22 6:45 ` Oskari Pirhonen
2023-12-22 14:23 ` Daniel Kiper
2023-12-21 11:02 ` Oliver Steffen
2023-12-22 14:18 ` Daniel Kiper
2024-02-22 13:35 ` Oliver Steffen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+bRGFoC2QmKGvRN6oyvtxVoboqQ-v-4v-mTnGxiF-aGw1a9Eg@mail.gmail.com \
--to=osteffen@redhat.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=mate.kukri@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).