From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Julian Andres Klode <julian.klode@canonical.com>, grub-devel@gnu.org
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
Robbie Harwood <rharwood@redhat.com>
Subject: Re: [PATCH] templates: Reinstate unused version comparison functions w/ warning
Date: Wed, 29 Nov 2023 13:28:30 -0500 [thread overview]
Message-ID: <38d70dc6-251b-4350-a8d6-9a55bdd095ea@efficios.com> (raw)
In-Reply-To: <20231129125159.2kr72yp4mctgwino@jak-t14-g3>
On 2023-11-29 07:51, Julian Andres Klode wrote:
> On Wed, Nov 29, 2023 at 01:42:55PM +0100, Julian Andres Klode wrote:
>> Revert "templates: Remove unused version comparison functions"
>> and add a warning to the functions that they are deprecated.
>>
>> Removing the functions directly caused a lot of upgrade issues
>> w/ custom user scripts that called the functions. In Debian and
>> Ubuntu, grub-mkconfig is invoked as a post-installation script
>> and would fail, causing upgrades to fail halfway through and
>> putting the package manager into an inconsistent state.
>
> FWIW, we get one bug per 2 weeks basically, for an interim
> Ubuntu release which generally does not receive much usage,
> that is a high number.
>
> The proposal is to pick this for 2.12 and directly after
> the release remove it again. Then users will have time
> to fix their scripts without systems breaking immediately.
I only removed those because they were now unused internally, without
expecting this impact for external users. The gradual deprecation plan
seems better indeed.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2023-11-29 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 12:42 [PATCH] templates: Reinstate unused version comparison functions w/ warning Julian Andres Klode
2023-11-29 12:51 ` Julian Andres Klode
2023-11-29 17:46 ` Daniel Kiper
2023-11-29 18:28 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38d70dc6-251b-4350-a8d6-9a55bdd095ea@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=daniel.kiper@oracle.com \
--cc=grub-devel@gnu.org \
--cc=julian.klode@canonical.com \
--cc=rharwood@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).