Re: [PATCH] fs/xfs: Handle non-continuous data blocks in directory extents

From: Daniel Kiper <dkiper@net-space.pl>
To: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH] fs/xfs: Handle non-continuous data blocks in directory extents
Date: Mon, 18 Mar 2024 15:41:36 +0100	[thread overview]
Message-ID: <20240318144136.arnn6lwrvphntepf@tomti.i.net-space.pl> (raw)
In-Reply-To: <CAEaD8JOKbQyeDQdmr9EosJv3Dk-qVjkd2fAs5vrgRVAxTUQtDA@mail.gmail.com>

On Sat, Mar 16, 2024 at 02:26:55AM +0300, Vladimir 'phcoder' Serbinenko wrote:
> On Sat, Feb 17, 2024 at 12:39 AM Jon DeVree <nuxi@vault24.org> wrote:
> >
> > On Thu, Feb 15, 2024 at 20:33:13 +0300, Vladimir 'phcoder' Serbinenko wrote:
> > > Is the pointer guaranteed to be aligned? If not you have to use unaligned
> > > access.
> >
> > I don't know what alignment guarantees grub_malloc() makes. As long as
> > they are close to what the regular C malloc() guarantees then it should
> > be fine.
>
> grub_malloc design guarantees the largest natural alignment of all types.
> grub_malloc implementation guarantees alignment of 4 * sizeof(void*).
>
> My concern was that the pointer is moved after alloc but it turns own
> it was not the case.
> So there are no unaligned access concerns
>
> The code still violates cast-align and strict aliasing invariants but
> so is the rest of XFS code.
> So I'm happy to merge this patch
>
> Reviewed-By: Vladimir Serbinenko <phcoder@gmail.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

I will push this patch together with other patches this week.
Sorry for delay...

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel