From: Daniel Kiper <dkiper@net-space.pl>
To: Mate Kukri <mate.kukri@canonical.com>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH] grub-install: Use `GRUB_DISTRIBUTOR` value as EFI boot option title
Date: Thu, 8 Feb 2024 19:31:12 +0100 [thread overview]
Message-ID: <20240208183112.zgxf2mhaxeo3jwt7@tomti.i.net-space.pl> (raw)
In-Reply-To: <CAAfJHtoBKN2dGEFC_nd_wAJgFXUQ5OkTKBj6SXyzpOSeqEN8TQ@mail.gmail.com>
On Thu, Feb 01, 2024 at 10:09:04AM +0000, Mate Kukri wrote:
> We are going to be shipping something like this in Ubuntu as we would
> like our boot entries to be called "Ubuntu" instead of "ubuntu".
>
> I wonder if other users of GRUB would find this naming approach
> better, I could gate this behind a command line option if the patch
> is easier to accept that way.
>
> A note here is that, the Windows platform efivar code should be fixed
> if this getting merged, but my first attempt to do so ended in
> frustration,
> because it definitely does not behave the same way as Unix, namely:
> - When looking for an entry to re-use, the name comparison is
> case-sensitive prefix match as opposed to a case-insensitive substring
> search.
> - The Windows code just searches for an entry to re-use, or an empty
> entry to fill, but unlike Unix, the existing entries with a matching
> name are not deleted.
I would be more than happy if you post this patch together with Windows
code fix. Could you do that?
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2024-02-08 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 9:29 [PATCH] grub-install: Use `GRUB_DISTRIBUTOR` value as EFI boot option title Mate Kukri
2024-02-01 10:09 ` Mate Kukri
2024-02-08 18:31 ` Daniel Kiper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208183112.zgxf2mhaxeo3jwt7@tomti.i.net-space.pl \
--to=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=mate.kukri@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).