From: Daniel Kiper <dkiper@net-space.pl>
To: Mate Kukri <mate.kukri@canonical.com>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH v4] grub-install: Delay copying files to {grubdir, platdir} after install_device was validated.
Date: Wed, 29 Nov 2023 20:27:21 +0100 [thread overview]
Message-ID: <20231129192721.jam4kuzzbdu4jaf7@tomti.i.net-space.pl> (raw)
In-Reply-To: <20231124083256.4140789-1-mate.kukri@canonical.com>
On Fri, Nov 24, 2023 at 08:32:57AM +0000, Mate Kukri wrote:
> Previously grub-install copied modules to grubdir before doing any validation on
> the install_device.
>
> When grub-install was called with an invalid install_device, modules
> were already copied to /boot before it found out and was forced to rely
> on atexit rollback.
>
> This patch delays copying the modules after at least some install_device
> validation was done, and thus reduces reliance on successful rollback.
>
> Signed-off-by: Mate Kukri <mate.kukri@canonical.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2023-11-29 19:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 8:32 [PATCH v4] grub-install: Delay copying files to {grubdir, platdir} after install_device was validated Mate Kukri
2023-11-29 19:27 ` Daniel Kiper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129192721.jam4kuzzbdu4jaf7@tomti.i.net-space.pl \
--to=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=mate.kukri@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).