From: Oliver Steffen <osteffen@redhat.com>
To: grub-devel@gnu.org
Cc: Daniel Axtens <dja@axtens.net>,
Daniel Kiper <dkiper@net-space.pl>,
Vladimir Serbinenko <phcoder@gmail.com>,
Tobias Powalowski <tobias.powalowski@googlemail.com>,
Oliver Steffen <osteffen@redhat.com>
Subject: [PATCH v2 2/3] bli: Add explicit dependency on the part_gpt module
Date: Wed, 15 Nov 2023 21:08:01 +0100 [thread overview]
Message-ID: <20231115200802.563564-3-osteffen@redhat.com> (raw)
In-Reply-To: <20231115200802.563564-1-osteffen@redhat.com>
The bli module has a "hidden" dependency on the part_gpt module, which
is not picked up automatically by the build system. One purpose of the
bli module is to communicate the GPT UUID of the partition Grub was
launched from to Linux user-space (systemd-gpt-auto-generator).
Without the part_gpt module, bli is not able to obtain the UUID. Since
bli does its work in the module initialization function, the order in
which the modules are loaded is also important: part_gpt needs to be
loaded before the bli module.
To solve this, track this dependency explicitly.
Note that the Boot Loader Interface specification, which bli aims to
implement, requires GPT formatted drives. The bli module ignores all
other partition formats.
Signed-off-by: Oliver Steffen <osteffen@redhat.com>
---
| 1 +
1 file changed, 1 insertion(+)
--git a/grub-core/extra_deps.lst b/grub-core/extra_deps.lst
index e69de29bb..f44ad6a0c 100644
--- a/grub-core/extra_deps.lst
+++ b/grub-core/extra_deps.lst
@@ -0,0 +1 @@
+depends bli part_gpt
--
2.41.0
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2023-11-15 20:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 20:07 [PATCH v2 0/3] Bli: fix hidden module dependency Oliver Steffen
2023-11-15 20:08 ` [PATCH v2 1/3] Allow explicit module dependencies Oliver Steffen
2023-11-15 20:08 ` Oliver Steffen [this message]
2023-11-15 20:08 ` [PATCH v2 3/3] bli: Improve documentation Oliver Steffen
2023-11-16 13:50 ` [PATCH v2 0/3] Bli: fix hidden module dependency Daniel Kiper
2023-11-21 15:00 ` Daniel Kiper
2023-11-29 19:43 ` Daniel Kiper
2023-11-29 20:54 ` Tobias Powalowski via Grub-devel
2023-11-30 13:36 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115200802.563564-3-osteffen@redhat.com \
--to=osteffen@redhat.com \
--cc=dja@axtens.net \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
--cc=tobias.powalowski@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).