From: Daniel Kiper <dkiper@net-space.pl>
To: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
Cc: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH 3/4] types: Split aligned and packed guids
Date: Tue, 7 Nov 2023 19:32:17 +0100 [thread overview]
Message-ID: <20231107183217.hcj6gx5dmlt3httm@tomti.i.net-space.pl> (raw)
In-Reply-To: <CAEaD8JMr2OWbD6JWHVDtYuvv3KPXpP=LK4AvUfe9M1vjy0eKbA@mail.gmail.com>
On Mon, Nov 06, 2023 at 10:59:08PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> > These casts looks strange for me. Could not we change the functions
> > declarations in the grub_efi_runtime_services? If not I think this
> > change should be explained in the commit message.
>
> New commit message:
>
> types: Split aligned and packed guids
>
> On ia64 alignment requirements are strict. When we pass a pointer to
> UUID it needs to be at least 4-byte aligned or EFI will crash.
> On the other hand in device path there is no padding for UUID, so we
> need 2 types in one formor another. Make 4-byte aligned and unaligned types
>
> The code is structured in a way to accept unaligned inputs
> in most cases and supply 4-byte aligned outputs.
>
> Efiemu case is a bit ugly because there inputs and outputs are
> reversed and so we need careful casts to account for this
> inversion.
LGTM though after more thinking I would add something similar
as a comment before the casts in the efiemu code.
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2023-11-07 18:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 19:35 [PATCH 3/4] types: Split aligned and packed guids Vladimir 'phcoder' Serbinenko
2023-10-31 21:43 ` John Paul Adrian Glaubitz
2023-11-06 17:49 ` Daniel Kiper
2023-11-06 21:59 ` Vladimir 'phcoder' Serbinenko
2023-11-07 18:32 ` Daniel Kiper [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-07 15:06 Vladimir 'phcoder' Serbinenko
2023-10-17 16:41 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107183217.hcj6gx5dmlt3httm@tomti.i.net-space.pl \
--to=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).