From: Daniel Kiper <dkiper@net-space.pl>
To: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH v2] gzio: Avoid spurious failures
Date: Mon, 6 Nov 2023 19:24:16 +0100 [thread overview]
Message-ID: <20231106182416.qjkfxyiuoew7y7wo@tomti.i.net-space.pl> (raw)
In-Reply-To: <CAEaD8JMyK2pREqto2G_kuQsWLjMryW+sqh5nvDiT+x+TQ5Zc9g@mail.gmail.com>
On Tue, Oct 31, 2023 at 08:53:41PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> On Tue, Oct 31, 2023 at 7:28 PM Jason Andryuk <jandryuk@gmail.com> wrote:
> >
> > grub_gzio_read_real() uses grub_errno to identify decompression failures
> > when the function completes. Its callees in gzio.c are void-returning
> > functions that set grub_errno on their exit paths.
> >
> > A Fedora 38 machine was observed to fail `multiboot2 /xen.gz` with
> > "premature end of file". xen.gz was well formed and could be
> > successfully gunzip-ed in Linux.
> >
> > The TPM is flaky and produces errors when the verifier tries to extend
> > PCRs with measurements. Logs show "Unkown TPM error" and grub_errno is
> > set to GRUB_ERR_UNKNOWN_DEVICE. This pre-existing grub_errno causes an
> > otherwise successful grub_gzio_read_real() call to return error.
> This bus is likely to create other problems as well. Why not fix it?
> If this error is meant to be ignored rather than stop loading, then it
> should be discarded early, possibly printed. If it should stop loading
> then this should really stop and not even get here
Jason, this makes me wonder what GRUB version you use. Do you have this
commit afdef4a56 (tpm: Enable boot despite unknown firmware failure)?
I am not sure I did not ask you about this earlier...
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2023-11-06 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 18:27 [PATCH v2] gzio: Avoid spurious failures Jason Andryuk
2023-10-31 19:53 ` Vladimir 'phcoder' Serbinenko
2023-11-06 18:24 ` Daniel Kiper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106182416.qjkfxyiuoew7y7wo@tomti.i.net-space.pl \
--to=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).