Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <>
To: "D. Ben Knoble via GitGitGadget" <>
	 Felipe Contreras <>,
	"D. Ben Knoble" <>
Subject: Re: [PATCH] completion: zsh: stop leaking local cache variable
Date: Tue, 30 Apr 2024 16:18:49 -0700	[thread overview]
Message-ID: <xmqqzftawiau.fsf@gitster.g> (raw)
In-Reply-To: <> (D. Ben Knoble via GitGitGadget's message of "Tue, 30 Apr 2024 21:53:15 +0000")

"D. Ben Knoble via GitGitGadget" <> writes:

> Commit beb6ee7163 (completion: extract repository discovery from
> __gitdir(), 2017-02-03) anticipated this problem by marking
> __git_repo_path as local in __git_main and __gitk_main for Bash
> completion but did not give the same mark to _git for Zsh completion.
> Thus make __git_repo_path local for Zsh completion, too.

Will queue.  The explanation makes tons of sense.


      reply	other threads:[~2024-04-30 23:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 21:53 [PATCH] completion: zsh: stop leaking local cache variable D. Ben Knoble via GitGitGadget
2024-04-30 23:18 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzftawiau.fsf@gitster.g \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).