* [PATCH] t4002: fix test #63 (missing whitespace)
@ 2023-07-25 6:34 Andreas Herrmann
2023-07-25 7:10 ` Eric Sunshine
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Herrmann @ 2023-07-25 6:34 UTC (permalink / raw)
To: git; +Cc: Andreas Herrmann
Add missing whitespace between 'test_expect_success' and test case
description for last test. Without this, we get:
t4002-diff-basic.sh: line 412: test_expect_successdiff can read from stdin: command not found
Signed-off-by: Andreas Herrmann <aherrmann@suse.de>
---
t/t4002-diff-basic.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh
index d524d4057d..e6b6739426 100755
--- a/t/t4002-diff-basic.sh
+++ b/t/t4002-diff-basic.sh
@@ -401,9 +401,10 @@ test_expect_success 'diff-tree B A == diff-tree -R A B' '
test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' '
git diff-tree -r $tree_B $tree_A >.test-a &&
git diff-tree -r -R $tree_A $tree_B >.test-b &&
- cmp -s .test-a .test-b'
+ cmp -s .test-a .test-b
+'
-test_expect_success'diff can read from stdin' '
+test_expect_success 'diff can read from stdin' '
test_must_fail git diff --no-index -- MN - < NN |
grep -v "^index" | sed "s#/-#/NN#" >.test-a &&
test_must_fail git diff --no-index -- MN NN |
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] t4002: fix test #63 (missing whitespace)
2023-07-25 6:34 [PATCH] t4002: fix test #63 (missing whitespace) Andreas Herrmann
@ 2023-07-25 7:10 ` Eric Sunshine
2023-07-25 16:49 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sunshine @ 2023-07-25 7:10 UTC (permalink / raw)
To: Andreas Herrmann; +Cc: git
On Tue, Jul 25, 2023 at 2:48 AM Andreas Herrmann <aherrmann@suse.de> wrote:
> Add missing whitespace between 'test_expect_success' and test case
> description for last test. Without this, we get:
>
> t4002-diff-basic.sh: line 412: test_expect_successdiff can read from stdin: command not found
>
> Signed-off-by: Andreas Herrmann <aherrmann@suse.de>
Thanks for finding this problem and submitting a fix. You're the
second person to do so[1].
[1]: https://lore.kernel.org/git/pull.1545.git.git.1689341410476.gitgitgadget@gmail.com/
> diff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh
> @@ -401,9 +401,10 @@ test_expect_success 'diff-tree B A == diff-tree -R A B' '
> test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' '
> git diff-tree -r $tree_B $tree_A >.test-a &&
> git diff-tree -r -R $tree_A $tree_B >.test-b &&
> - cmp -s .test-a .test-b'
> + cmp -s .test-a .test-b
> +'
This minor style fixup could be resubmitted as a standalone patch,
though it might be too minor to worry about.
> -test_expect_success'diff can read from stdin' '
> +test_expect_success 'diff can read from stdin' '
> test_must_fail git diff --no-index -- MN - < NN |
> grep -v "^index" | sed "s#/-#/NN#" >.test-a &&
> test_must_fail git diff --no-index -- MN NN |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] t4002: fix test #63 (missing whitespace)
2023-07-25 7:10 ` Eric Sunshine
@ 2023-07-25 16:49 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2023-07-25 16:49 UTC (permalink / raw)
To: Eric Sunshine; +Cc: Andreas Herrmann, git
Eric Sunshine <sunshine@sunshineco.com> writes:
> Thanks for finding this problem and submitting a fix. You're the
> second person to do so[1].
>
> [1]: https://lore.kernel.org/git/pull.1545.git.git.1689341410476.gitgitgadget@gmail.com/
>
>> diff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh
>> @@ -401,9 +401,10 @@ test_expect_success 'diff-tree B A == diff-tree -R A B' '
>> test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' '
>> git diff-tree -r $tree_B $tree_A >.test-a &&
>> git diff-tree -r -R $tree_A $tree_B >.test-b &&
>> - cmp -s .test-a .test-b'
>> + cmp -s .test-a .test-b
>> +'
>
> This minor style fixup could be resubmitted as a standalone patch,
> though it might be too minor to worry about.
Thanks for a quick review and encouraging words. I do not mind a
patch with only the above hunk but of course the title and the log
message would have to be updated ;-).
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-25 16:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 6:34 [PATCH] t4002: fix test #63 (missing whitespace) Andreas Herrmann
2023-07-25 7:10 ` Eric Sunshine
2023-07-25 16:49 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).