From: Junio C Hamano <gitster@pobox.com>
To: "Ville Skyttä" <ville.skytta@iki.fi>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] completion: fix prompt with unset SHOWCONFLICTSTATE in nounset mode
Date: Mon, 01 Apr 2024 12:38:54 -0700 [thread overview]
Message-ID: <xmqqwmpg98kx.fsf@gitster.g> (raw)
In-Reply-To: <CABr9L5CLNCYFcta0aMApkyxr_jW9wycY8GmJsUPr9kg1smv+Kg@mail.gmail.com> ("Ville Skyttä"'s message of "Mon, 1 Apr 2024 19:10:30 +0000")
Ville Skyttä <ville.skytta@iki.fi> writes:
> TBH, I'd personally just rather patch the "vulnerable" reference to
> guard against this. Sent that approach in another mail with subject
> "[PATCH] completion: protect prompt against unset SHOWUPSTREAM in
> nounset mode".
Yup, that would be more future-proof. Will queue. Thanks.
prev parent reply other threads:[~2024-04-01 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 11:30 [PATCH] completion: fix prompt with unset SHOWCONFLICTSTATE in nounset mode Ville Skyttä
2024-04-01 15:31 ` Junio C Hamano
2024-04-01 17:07 ` Ville Skyttä
2024-04-01 17:26 ` Junio C Hamano
2024-04-01 19:10 ` Ville Skyttä
2024-04-01 19:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwmpg98kx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ville.skytta@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).