From: Junio C Hamano <gitster@pobox.com>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v4] sequencer: rectify empty hint in call of require_clean_work_tree()
Date: Thu, 24 Aug 2023 08:59:10 -0700 [thread overview]
Message-ID: <xmqqr0nsbfe9.fsf@gitster.g> (raw)
In-Reply-To: <20230824150046.802008-1-oswald.buddenhagen@gmx.de> (Oswald Buddenhagen's message of "Thu, 24 Aug 2023 17:00:46 +0200")
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
> The canonical way to represent "no error hint" is making it NULL, which
> shortcuts the error() call altogether. This fixes the output by removing
> the line which said just "error:", which would appear when the worktree
> is dirtied while editing the initial rebase todo file.
> ...
> v4:
> - fixed reproduction instructions
Nice. Will queue and mark it for 'next'. Thanks.
next prev parent reply other threads:[~2023-08-24 16:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:22 [PATCH] sequencer: rectify empty hint in call of require_clean_work_tree() Oswald Buddenhagen
2023-04-27 7:58 ` Oswald Buddenhagen
2023-04-27 21:13 ` Junio C Hamano
2023-04-27 22:33 ` Oswald Buddenhagen
2023-05-02 18:57 ` Felipe Contreras
2023-05-03 7:15 ` Oswald Buddenhagen
2023-08-07 17:09 ` [PATCH v2] " Oswald Buddenhagen
2023-08-07 20:19 ` Junio C Hamano
2023-08-09 17:15 ` [PATCH v3] " Oswald Buddenhagen
2023-08-09 21:44 ` Junio C Hamano
2023-08-10 11:24 ` Oswald Buddenhagen
2023-08-10 16:04 ` Junio C Hamano
2023-08-24 15:00 ` [PATCH v4] " Oswald Buddenhagen
2023-08-24 15:59 ` Junio C Hamano [this message]
2023-08-09 1:24 ` [PATCH v2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr0nsbfe9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=oswald.buddenhagen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).