Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: Marcel Telka <marcel@telka.sk>,
	 git@vger.kernel.org,  Jeff Hostetler <jeffhostetler@github.com>
Subject: Re: t0211-trace2-perf.sh: typo patern -> pattern
Date: Wed, 15 May 2024 10:09:46 -0700	[thread overview]
Message-ID: <xmqqr0e3vw6d.fsf@gitster.g> (raw)
In-Reply-To: <fe76b111-f080-5d1f-c51f-591e9381c116@jeffhostetler.com> (Jeff Hostetler's message of "Wed, 15 May 2024 12:59:10 -0400")

Jeff Hostetler <git@jeffhostetler.com> writes:

> On 5/15/24 12:52 PM, Junio C Hamano wrote:
>> Marcel Telka <marcel@telka.sk> writes:
>> 
>>> Hi,
>>>
>>> There seems to be apparent typo in the t/t0211-trace2-perf.sh file:
>>>
>>>
>>> --- a/t/t0211-trace2-perf.sh
>>> +++ b/t/t0211-trace2-perf.sh
>>> @@ -233,7 +233,7 @@ have_counter_event () {
>>>            pattern="d0|${thread}|${event}||||${category}|name:${name}
>>> value:${value}" &&
>>>   -       grep "${patern}" ${file}
>>> +       grep "${pattern}" ${file}
>>>   }
>>>     test_expect_success 'global counter test/test1' '
>> Ah, indeed, there is no assignment to the variable $patern so this
>> grep matches by looking for all the empty strings in the file X-<.
>> 
>
> OOPS.
>
> Thanks for the fix.

Nobody sent an applicable patch yet, though ;-)

      reply	other threads:[~2024-05-15 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15 14:35 t0211-trace2-perf.sh: typo patern -> pattern Marcel Telka
2024-05-15 16:52 ` Junio C Hamano
2024-05-15 16:59   ` Jeff Hostetler
2024-05-15 17:09     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr0e3vw6d.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=jeffhostetler@github.com \
    --cc=marcel@telka.sk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).