From: Junio C Hamano <gitster@pobox.com>
To: Marc Branchaud <marcnarc@xiplink.com>
Cc: git@vger.kernel.org
Subject: Re: [Q] rebase -i: turn "pick" to "edit", make no change, what should happen?
Date: Fri, 17 May 2024 10:04:41 -0700 [thread overview]
Message-ID: <xmqqo794jro6.fsf@gitster.g> (raw)
In-Reply-To: <6620412e-a8ea-40fb-8823-13c4b33e9808@xiplink.com> (Marc Branchaud's message of "Fri, 17 May 2024 08:42:41 -0400")
Marc Branchaud <marcnarc@xiplink.com> writes:
> On 2024-05-16 15:21, Junio C Hamano wrote:
>> What should happen when I turn "pick" to "edit" in a "rebase -i"
>> session, check what got checked out in the working tree, find it
>> satisfactory and decide not to make any change to the files, and say
>> "rebase --continue"?
>> The current implementation seems to just move to the next step,
>> without offering a chance to edit the log message. I do not know
>> offhand if this is something we changed recently, or if it has been
>> that way forever.
>
> It's been this way forever (or close enough; I've been using Git since
> ~2010).
Thanks.
prev parent reply other threads:[~2024-05-17 17:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 19:21 [Q] rebase -i: turn "pick" to "edit", make no change, what should happen? Junio C Hamano
2024-05-16 22:18 ` Sean Allred
2024-05-17 7:09 ` Junio C Hamano
2024-05-17 7:32 ` Patrick Steinhardt
2024-05-17 8:54 ` Dragan Simic
2024-05-17 13:52 ` Sean Allred
2024-05-17 15:17 ` Junio C Hamano
2024-05-17 12:42 ` Marc Branchaud
2024-05-17 17:04 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo794jro6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=marcnarc@xiplink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).