From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
nsengaw4c via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, nsengaw4c <nsengiyumvawilberforce@gmail.com>,
Christian Couder <christian.couder@gmail.com>,
Hariom Verma <hariom18599@gmail.com>
Subject: Re: [PATCH v3] [OUTREACHY] t1002: modernize outdated conditional
Date: Fri, 14 Oct 2022 11:57:47 -0700 [thread overview]
Message-ID: <xmqqlepi8c7o.fsf@gitster.g> (raw)
In-Reply-To: <cc0a6adb-d894-77b3-2a65-9042237c07b5@github.com> (Derrick Stolee's message of "Fri, 14 Oct 2022 13:54:39 -0400")
Derrick Stolee <derrickstolee@github.com> writes:
> Nsengiyumva: you'll want to be careful to edit your pull request
> description on GitHub before running the "/submit" chatop. Your
> current description has a paste of your commit message followed by
> the contributing template. The pull request description becomes
> your cover letter (in the case of multiple patches) or a commentary
> section after the commit message (in this case of a single patch).
>
> The description is a good place to say things like "I started
> working on this because of a mailing list thread..." or "I'm not
> sure if I've tested everything enough".
Good advice.
> The "cc:" lines should _not_ be in the commit message at all, which
> is what's visible in the patch.
I agree that it would probably be better without CC: in the trailer
in this case. Some projects seem to use the CC: in the trailer to
signal that these people have been notified, without implying
anything about their reaction (i.e. when the author cannot use
reviewed-by or acked-by). We are not that large a community, so I
personally do not see a need to use such a trailer around here. But
that is only a local convention in this project.
Thanks.
next prev parent reply other threads:[~2022-10-14 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 2:06 [PATCH] [OUTREACHY] t1002: modernize outdated conditional nsengaw4c via GitGitGadget
2022-10-14 5:05 ` Junio C Hamano
2022-10-14 7:47 ` [PATCH v2] " nsengaw4c via GitGitGadget
2022-10-14 8:01 ` [PATCH v3] " nsengaw4c via GitGitGadget
2022-10-14 16:15 ` Junio C Hamano
2022-10-14 16:21 ` Derrick Stolee
2022-10-14 16:58 ` Eric Sunshine
2022-10-14 17:54 ` Derrick Stolee
2022-10-14 18:57 ` Junio C Hamano [this message]
2022-10-14 19:06 ` Junio C Hamano
2022-10-14 19:14 ` Eric Sunshine
2022-10-14 20:41 ` Junio C Hamano
2022-10-14 20:19 ` Philip Oakley
2022-10-14 20:42 ` Junio C Hamano
2022-10-14 18:28 ` [PATCH v4] " nsengaw4c via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlepi8c7o.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hariom18599@gmail.com \
--cc=nsengiyumvawilberforce@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).