From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: rsbecker@nexbridge.com, git@vger.kernel.org,
Elijah Newren <newren@gmail.com>
Subject: Re: [BUG] Git 2.41.0-rc0 - Compile Error ALLOC_GROW
Date: Tue, 16 May 2023 10:19:48 -0700 [thread overview]
Message-ID: <xmqqlehourbf.fsf@gitster.g> (raw)
In-Reply-To: <ZGO4LesPe4A2ftdm@nand.local> (Taylor Blau's message of "Tue, 16 May 2023 13:06:53 -0400")
Taylor Blau <me@ttaylorr.com> writes:
Ah, alloc.h was introduced and everybody who took ALLOC_GROW() from
git-compat-util.h (or was it cache.h?) now includes it, but
apparently Elijah forgot run-command.c and nobody caught this.
I wonder if there are other leftover ones that we haven't caught?
$ git grep -l '[^_]ALLOC_GROW(' \*.c | sort >/var/tmp/1
$ git grep -l 'alloc\.h' \*.c | sort >/var/tmp/2
$ comm -23 /var/tmp/[12]
compat/simple-ipc/ipc-unix-socket.c
run-command.c
But the former one is only in a comment, so it probably is OK.
next prev parent reply other threads:[~2023-05-16 17:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 16:58 [BUG] Git 2.41.0-rc0 - Compile Error ALLOC_GROW rsbecker
2023-05-16 17:06 ` Taylor Blau
2023-05-16 17:19 ` Junio C Hamano [this message]
2023-05-16 17:24 ` [PATCH] run-command.c: need alloc.h for our own at-exit handler emulation Junio C Hamano
2023-05-16 17:33 ` rsbecker
2023-05-16 17:57 ` Taylor Blau
2023-05-16 18:01 ` Taylor Blau
2023-05-16 18:44 ` Junio C Hamano
2023-05-16 18:47 ` Taylor Blau
2023-05-16 18:53 ` Junio C Hamano
2023-05-16 17:56 ` [PATCH] run-command.c: fix missing include under `NO_PTHREADS` Taylor Blau
2023-05-16 19:12 ` Junio C Hamano
2023-05-16 19:13 ` rsbecker
2023-05-16 21:33 ` Taylor Blau
2023-05-18 4:16 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlehourbf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).