From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] archive: convert queue_directory to struct object_id
Date: Fri, 27 Aug 2021 14:18:52 -0700 [thread overview]
Message-ID: <xmqqk0k6a8n7.fsf@gitster.g> (raw)
In-Reply-To: <YSlN0+ZCpDqoem9J@camp.crustytoothpaste.net> (brian m. carlson's message of "Fri, 27 Aug 2021 20:40:51 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> On 2021-08-27 at 19:59:16, René Scharfe wrote:
>> Pass the struct object_id on instead of just its hash member.
>> This is simpler and avoids the need to guess the algorithm.
>
> Seems reasonable.
I guess this is about the oidread() you added at the end of the
function, so I'd take the above as your Acked-by ;-)
Thanks, both. Will queue.
prev parent reply other threads:[~2021-08-27 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 19:59 [PATCH] archive: convert queue_directory to struct object_id René Scharfe
2021-08-27 20:40 ` brian m. carlson
2021-08-27 21:18 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0k6a8n7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).