From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>
Subject: Re: PATCH] bisect--helper: plug strvec leak in bisect_start()
Date: Thu, 06 Oct 2022 14:53:03 -0700 [thread overview]
Message-ID: <xmqqk05cipq8.fsf@gitster.g> (raw)
In-Reply-To: <221006.86a668r5mf.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 06 Oct 2022 23:35:19 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>> The common pattern for run_command_v_opt() callers that don't need a
>>> dynamic list is exactly that.
So, scratching "that don't need a dynamic list", and with ...
> Other prior art, just taking the char[] ones (and not even all of them):
> ...
> builtin/merge-index.c:12:37: error: initializer element is not computable at load time [-Werror=pedantic]
> 12 | const char *arguments[] = { pgm, "", "", "", path, "", "", "", NULL };
> builtin/remote.c:95:41: error: initializer element is not computable at load time [-Werror=pedantic]
> 95 | const char *argv[] = { "fetch", name, NULL, NULL };
> archive.c:408:33: error: initializer element is not computable at load time [-Werror=pedantic]
> 408 | const char *paths[] = { path, NULL };
> merge-ort.c:1699:45: error: initializer element is not computable at load time [-Werror=pedantic]
> 1699 | "--all", merged_revision, NULL };
... these, I agree that we are not making anything worse.
Thanks.
next prev parent reply other threads:[~2022-10-06 21:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 16:06 PATCH] bisect--helper: plug strvec leak in bisect_start() René Scharfe
2022-10-05 7:29 ` Ævar Arnfjörð Bjarmason
2022-10-05 15:43 ` René Scharfe
2022-10-05 19:44 ` Junio C Hamano
2022-10-06 21:35 ` Ævar Arnfjörð Bjarmason
2022-10-06 21:53 ` Junio C Hamano [this message]
2022-10-07 15:08 ` [PATCH v2] bisect--helper: plug strvec leak René Scharfe
2022-10-07 17:21 ` Junio C Hamano
2022-10-11 2:39 ` Jeff King
2022-10-11 5:42 ` Junio C Hamano
2022-10-11 7:29 ` Ævar Arnfjörð Bjarmason
2022-10-11 13:21 ` Jeff King
2022-10-11 13:20 ` Jeff King
2022-10-11 17:11 ` Junio C Hamano
2022-10-11 18:13 ` Ævar Arnfjörð Bjarmason
2022-10-11 21:43 ` Junio C Hamano
2022-10-14 19:44 ` Jeff King
2022-10-14 20:23 ` Junio C Hamano
2022-10-15 6:51 ` René Scharfe
2022-10-15 18:21 ` Jeff King
2022-10-05 19:41 ` PATCH] bisect--helper: plug strvec leak in bisect_start() Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk05cipq8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).