From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jonas Bernoulli <jonas@bernoul.li>, git@vger.kernel.org
Subject: Re: "submodule foreach" much slower than removed "submodule--helper --list"
Date: Sat, 15 Oct 2022 11:16:06 -0700 [thread overview]
Message-ID: <xmqqilkl54wp.fsf@gitster.g> (raw)
In-Reply-To: <Y0r4US7AKxT/BLiY@coredump.intra.peff.net> (Jeff King's message of "Sat, 15 Oct 2022 14:13:37 -0400")
Jeff King <peff@peff.net> writes:
> Yeah, that's not too surprising that it's slower. It's exec-ing a bunch
> of shells to do that.
> ...
> I'm not sure if those are exactly equivalent, either. It looks like the
> old code was probably respecting submodule active markers (though in my
> test repo without the submodule actually checked out, it's still
> reported). There is probably room for a user-facing "git submodule list"
> command, but again, I don't really know enough about the space to say
> what it should report.
We could mimic "find" and make "foreach" that has no action default
to an equivalent of "echo" that is done internally without forking.
next prev parent reply other threads:[~2022-10-15 18:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 16:50 "submodule foreach" much slower than removed "submodule--helper --list" Jonas Bernoulli
2022-10-15 17:34 ` Jonas Bernoulli
2022-10-15 18:13 ` Jeff King
2022-10-15 18:16 ` Junio C Hamano [this message]
2022-10-15 18:23 ` Jeff King
2022-10-15 18:37 ` Junio C Hamano
2022-10-15 22:40 ` Junio C Hamano
2022-10-17 17:02 ` Jeff King
2022-11-07 11:01 ` Matti Möll
2022-11-08 2:50 ` Taylor Blau
2022-11-08 3:37 ` Ævar Arnfjörð Bjarmason
2022-10-17 16:50 ` Ævar Arnfjörð Bjarmason
2022-10-17 17:46 ` Jeff King
2022-10-21 14:58 ` Jonas Bernoulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilkl54wp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonas@bernoul.li \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).